Issues with bootstrap plugins

[turbolinks]

Issues with bootstrap plugins

[protocarl]

Pull request on bootstrap addressing this: twbs/bootstrap#5308

[caarlos0]

thanks :)

[davydotcom]

also, twitter-bootstrap-turbo gem "clone" of twitter-bootstrap-rails with turbo support is available in the interim. It uses a different solution to solving the problem, I actually prefer the pull-request solution over mine, but they both work.

[caarlos0]

I see. currently I using twitter-bootstrap-turbo, and it's working well for me...

[ryw]

Note to future visitor using SCSS via https://github.com/anjlab/bootstrap-rails —

I've applied @davydotcom's fix to that project in my fork: https://github.com/ryw/bootstrap-rails

[ryw]

@yury mentioned jquery.turbolinks as a possible fix to the issue as well.

I wonder if turbolinks should detect if app has jQuery, and if so, apply the following code, that wil help with this issue on a multitude of plugins, not just bootstrap.

From https://github.com/kossnocorp/jquery.turbolinks/blob/master/src/jquery.turbolinks.coffee

$ = require?('jquery') || window.jQuery

# List for store callbacks passed to `$` or `$.ready`
callbacks = []

# Call each callback in list
ready = ->
  callback() for callback in callbacks

# Bind `ready` to DOM ready event
$(ready)

# Store callbacks in list on `$` and `$.ready`
$.fn.ready = (callback) ->
  callbacks.push(callback)

# Bind `ready` to Tubolinks page change event
$(document).on('page:change', ready)

[davydotcom]

That's pretty nice, however maybe out of scope here... One note is he binds to page:change where page:load would be more appropriate

Sent from my iPhone

On Oct 9, 2012, at 6:45 PM, Ryan Walker [email protected] wrote:

@yury mentioned jquery.turbolinks as a possible fix to the issue as well.

I wonder if turbolinks should detect if app has jquery, and if so, apply the following code from https://github.com/kossnocorp/jquery.turbolinks/blob/master/src/jquery.turbolinks.coffee

$ = require?('jquery') || window.jQuery

List for store callbacks passed to $ or $.ready

callbacks = []

Call each callback in list

ready = ->
callback() for callback in callbacks

Bind ready to DOM ready event

$(ready)

Store callbacks in list on $ and $.ready

$.fn.ready = (callback) ->
callbacks.push(callback)

Bind ready to Tubolinks page change event

$(document).on('page:change', ready)
—
Reply to this email directly or view it on GitHub.

[davydotcom]

Man the more I look at jquery.turbolinks, the more I think this is awesome. @dhh, would potentially adding this as another asset in the gem be a good idea? Something like add this to your manifest for jquery support. etc.

[davydotcom]

The ONLY, downside I see to kossonocopr jquery.turbolinks solution is that the order in which these js files are included become very important.

[caarlos0]

👍 @davydotcom

With this solution, the turbolinks JS should always be the last included.

Also, I'm not a JS-ninja, but I do believe that it will generate a dependency of jQuery to turbolinks, huh?

[davydotcom]

Not if its a seperate js file that you can require in your manifest optionally.

[caarlos0]

seems legit.

[dhh]

Having it as a separate file sounds fine.

On Oct 10, 2012, at 1:46, David Estes [email protected] wrote:

Man the more I look at jquery.turbolinks, the more I think this is awesome. @dhh, would potentially adding this as another asset in the gem be a good idea? Something like add this to your manifest for jquery support. etc.

—
Reply to this email directly or view it on GitHub.

[caarlos0]

👍