Giter Site home page Giter Site logo

Comments (20)

sstephenson avatar sstephenson commented on July 17, 2024

Oh, and good luck with this one. Chrome provides essentially no debugging tools aside from alert.

from turbolinks-classic.

davydotcom avatar davydotcom commented on July 17, 2024

Oh, this one is going to be just awesome. Since Chrome is simply using a UIWebView control they may be using some interesting js hacks to accomplish a true browser feel in the first place.

from turbolinks-classic.

davydotcom avatar davydotcom commented on July 17, 2024

have an idea that might fix this. I know Chrome for iOS is a WebView wrapper. usually the only way to get event hooks out to native Objective C is to use urls and catch them in the delegate for a UIWebview. It may be possible to fix this if we restrict turbolinks to only fire on links that have no protocol defined or have http or https ?

from turbolinks-classic.

rahearn avatar rahearn commented on July 17, 2024

FWIW, I tested a site I wrote that uses turbolinks 0.6.1 today in Chrome for iOS and it seems to work fine.

from turbolinks-classic.

davydotcom avatar davydotcom commented on July 17, 2024

Sweet, is it actually working or doing its graceful fallback?

On Wednesday, December 19, 2012, Ryan Ahearn wrote:

FWIW, I tested a site I wrote that uses turbolinks 0.6.1 today in Chrome
for iOS and it seems to work fine.


Reply to this email directly or view it on GitHubhttps://github.com//issues/82#issuecomment-11535191.

from turbolinks-classic.

rahearn avatar rahearn commented on July 17, 2024

I'm not actually sure. It's not falling back to a full page reload as there's only one request for the page. Is there a way to tell if its working based on production logs?

On Wednesday, December 19, 2012 at 10:59 AM, David Estes wrote:

Sweet, is it actually working or doing its graceful fallback?

On Wednesday, December 19, 2012, Ryan Ahearn wrote:

FWIW, I tested a site I wrote that uses turbolinks 0.6.1 today in Chrome
for iOS and it seems to work fine.


Reply to this email directly or view it on GitHubhttps://github.com//issues/82#issuecomment-11535191.


Reply to this email directly or view it on GitHub (#82 (comment)).

from turbolinks-classic.

davydotcom avatar davydotcom commented on July 17, 2024

If its not doing a full reload than yup it's working. Awesome... @dhh I
think we can close this

On Wednesday, December 19, 2012, Ryan Ahearn wrote:

I'm not actually sure. It's not falling back to a full page reload as
there's only one request for the page. Is there a way to tell if its
working based on production logs?

On Wednesday, December 19, 2012 at 10:59 AM, David Estes wrote:

Sweet, is it actually working or doing its graceful fallback?

On Wednesday, December 19, 2012, Ryan Ahearn wrote:

FWIW, I tested a site I wrote that uses turbolinks 0.6.1 today in
Chrome
for iOS and it seems to work fine.


Reply to this email directly or view it on GitHub<
https://github.com/rails/turbolinks/issues/82#issuecomment-11535191>.


Reply to this email directly or view it on GitHub (
#82 (comment)).


Reply to this email directly or view it on GitHubhttps://github.com//issues/82#issuecomment-11535371.

from turbolinks-classic.

dhh avatar dhh commented on July 17, 2024

Sam, can you confirm if all is well?

from turbolinks-classic.

davydotcom avatar davydotcom commented on July 17, 2024

This may be related to using the new Date().getTime instead of window.history.length patch

from turbolinks-classic.

sstephenson avatar sstephenson commented on July 17, 2024

Nope, just tried the latest Turbolinks on Basecamp and it's still not working in Chrome.

from turbolinks-classic.

rahearn avatar rahearn commented on July 17, 2024

Yes, I spoke too soon. I was expecting to see either a double request or a total lack of navigation for breakage. I am seeing problem 2 in the initial bug report, which is cause the turbolinks code to silently crash and the click event to be handled by the anchor tag. Never thought I'd be enjoying the benefits of graceful degradation in a fully js enabled browser.

Turbolinks is behaving properly in the Switch browser for iOS, so this might just be a bug in Chrome itself, and not a problem for every UIWebView based browser.

from turbolinks-classic.

dhh avatar dhh commented on July 17, 2024

Until this issue is fixed, we should detect Chrome for iOS as an incompatible browser, and just not activate turbolinks. Could someone make a pull request for that?

from turbolinks-classic.

davydotcom avatar davydotcom commented on July 17, 2024

i thought it was gracefully falling back already. am I wrong on that assumption?

from turbolinks-classic.

dhh avatar dhh commented on July 17, 2024

Yeah, we have custom code to detect and fallback in BCX right now:

if navigator.userAgent.match /CriOS\//
  # Temporary workaround for Turbolinks' incompatibility with Chrome iOS
  Turbolinks.visit = (url) ->
    window.location = url
  bcx.on document, "click", "a", (event) ->
    window.location = @href
    event.preventDefault()

from turbolinks-classic.

davydotcom avatar davydotcom commented on July 17, 2024

hah ok. one sec.

from turbolinks-classic.

davydotcom avatar davydotcom commented on July 17, 2024

@dhh there you go issue #161 pull has a check on initializeTurbolinks if browserIsntCriOS

from turbolinks-classic.

liamzebedee avatar liamzebedee commented on July 17, 2024

Hey all, has this been closed permanently as a non-fixable issue?

from turbolinks-classic.

liamzebedee avatar liamzebedee commented on July 17, 2024

Anyone have any idea as to the root cause? Push.js from the Ratchet framework is able to function in Chrome on iOS (by simply using replaceState), could someone explain why Ratchet needs specific access to window.history.state? I'd be willing to give it a try to fix, Turbolinks is much better :)

from turbolinks-classic.

javan avatar javan commented on July 17, 2024

It's worth revisiting the issues Sam outlined in his initial report. If it's working now in the latest Chrome for iOS, we can scope the browser check to older versions.

from turbolinks-classic.

brendon avatar brendon commented on July 17, 2024

Is this bug/problem/workaround present in Turbolinks 5?

from turbolinks-classic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.