Comments (20)
Oh, and good luck with this one. Chrome provides essentially no debugging tools aside from alert
.
from turbolinks-classic.
Oh, this one is going to be just awesome. Since Chrome is simply using a UIWebView control they may be using some interesting js hacks to accomplish a true browser feel in the first place.
from turbolinks-classic.
have an idea that might fix this. I know Chrome for iOS is a WebView wrapper. usually the only way to get event hooks out to native Objective C is to use urls and catch them in the delegate for a UIWebview. It may be possible to fix this if we restrict turbolinks to only fire on links that have no protocol defined or have http or https ?
from turbolinks-classic.
FWIW, I tested a site I wrote that uses turbolinks 0.6.1 today in Chrome for iOS and it seems to work fine.
from turbolinks-classic.
Sweet, is it actually working or doing its graceful fallback?
On Wednesday, December 19, 2012, Ryan Ahearn wrote:
FWIW, I tested a site I wrote that uses turbolinks 0.6.1 today in Chrome
for iOS and it seems to work fine.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/82#issuecomment-11535191.
from turbolinks-classic.
I'm not actually sure. It's not falling back to a full page reload as there's only one request for the page. Is there a way to tell if its working based on production logs?
On Wednesday, December 19, 2012 at 10:59 AM, David Estes wrote:
Sweet, is it actually working or doing its graceful fallback?
On Wednesday, December 19, 2012, Ryan Ahearn wrote:
FWIW, I tested a site I wrote that uses turbolinks 0.6.1 today in Chrome
for iOS and it seems to work fine.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/82#issuecomment-11535191.—
Reply to this email directly or view it on GitHub (#82 (comment)).
from turbolinks-classic.
If its not doing a full reload than yup it's working. Awesome... @dhh I
think we can close this
On Wednesday, December 19, 2012, Ryan Ahearn wrote:
I'm not actually sure. It's not falling back to a full page reload as
there's only one request for the page. Is there a way to tell if its
working based on production logs?On Wednesday, December 19, 2012 at 10:59 AM, David Estes wrote:
Sweet, is it actually working or doing its graceful fallback?
On Wednesday, December 19, 2012, Ryan Ahearn wrote:
FWIW, I tested a site I wrote that uses turbolinks 0.6.1 today in
Chrome
for iOS and it seems to work fine.—
Reply to this email directly or view it on GitHub<
https://github.com/rails/turbolinks/issues/82#issuecomment-11535191>.—
Reply to this email directly or view it on GitHub (
#82 (comment)).—
Reply to this email directly or view it on GitHubhttps://github.com//issues/82#issuecomment-11535371.
from turbolinks-classic.
Sam, can you confirm if all is well?
from turbolinks-classic.
This may be related to using the new Date().getTime instead of window.history.length patch
from turbolinks-classic.
Nope, just tried the latest Turbolinks on Basecamp and it's still not working in Chrome.
from turbolinks-classic.
Yes, I spoke too soon. I was expecting to see either a double request or a total lack of navigation for breakage. I am seeing problem 2 in the initial bug report, which is cause the turbolinks code to silently crash and the click event to be handled by the anchor tag. Never thought I'd be enjoying the benefits of graceful degradation in a fully js enabled browser.
Turbolinks is behaving properly in the Switch browser for iOS, so this might just be a bug in Chrome itself, and not a problem for every UIWebView based browser.
from turbolinks-classic.
Until this issue is fixed, we should detect Chrome for iOS as an incompatible browser, and just not activate turbolinks. Could someone make a pull request for that?
from turbolinks-classic.
i thought it was gracefully falling back already. am I wrong on that assumption?
from turbolinks-classic.
Yeah, we have custom code to detect and fallback in BCX right now:
if navigator.userAgent.match /CriOS\//
# Temporary workaround for Turbolinks' incompatibility with Chrome iOS
Turbolinks.visit = (url) ->
window.location = url
bcx.on document, "click", "a", (event) ->
window.location = @href
event.preventDefault()
from turbolinks-classic.
hah ok. one sec.
from turbolinks-classic.
@dhh there you go issue #161 pull has a check on initializeTurbolinks if browserIsntCriOS
from turbolinks-classic.
Hey all, has this been closed permanently as a non-fixable issue?
from turbolinks-classic.
Anyone have any idea as to the root cause? Push.js from the Ratchet framework is able to function in Chrome on iOS (by simply using replaceState), could someone explain why Ratchet needs specific access to window.history.state? I'd be willing to give it a try to fix, Turbolinks is much better :)
from turbolinks-classic.
It's worth revisiting the issues Sam outlined in his initial report. If it's working now in the latest Chrome for iOS, we can scope the browser check to older versions.
from turbolinks-classic.
Is this bug/problem/workaround present in Turbolinks 5?
from turbolinks-classic.
Related Issues (20)
- Page does not always scroll to the top when DOM loads too fast
- SVG anchors not working with turbolinks
- Turbolinks.visit, partial replacement & relative urls (& IE11)
- Not correctly inferring protocol with SSL, unless force_ssl is set HOT 2
- Redirect and reload full page HOT 1
- JavaScript part of turbolinks on npm HOT 11
- Enable Turbolinks on a-tags after adding content over AJAX HOT 1
- File type blacklist instead of whitelist
- Scroll position of data-turbolinks-permanent elements lost on navigation. HOT 3
- Webpage without title, after turbolink has title of undefined HOT 1
- Problems with JS HOT 1
- Rails 5 deprecations
- Would you please tell me how to add your library or whether it's necessary to add this library?
- Sorry for duplicate
- Progress bar causing capybara tests to fail
- Documentation does not explain how to install current turbolinks-classic version HOT 1
- temporary inside permanent
- Clicking browser back button from an error page to a non-error page, retains the styles of the error page
- Turbolinks.enableProgressBar() returns undefined
- How to binding "page:load" cache-preview
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from turbolinks-classic.