extractAssets should ignore certain types?

[turbolinks]

extractAssets should ignore certain types?

[dhh]

We should only reload on JS and CSS changes IMO. Browsers will unfortunately not pick up dynamically adding the rss link. Most are entirely removing rss support anyway as well.

On Oct 19, 2012, at 6:12, Jonathan del Strother [email protected] wrote:

Hi - I've been using Pjax in a limited scope for a while, but only just started trying out Turbolinks in our app, so forgive me if I'm missing something.

I'm struggling with the assetsChanged method always returning true for pretty much any two pages on our site, which then results in Turbolinks doing a full page reload. We have a number of oembed tags in our pages, as well as specialised RSS for differing areas of the site, and some legacy Facebook tags like rel=image_src.

I'm wondering if it would make sense to be able to tell Turbolinks to ignore link tags with certain type or rel attributes (eg "application/xml+oembed"). There are obvious problems with that approach - eg the ombed tags would still refer to an old page, but since they're intended for machine consumption only perhaps it doesn't matter. (RSS is a bit trickier... ideally you might replace the old RSS tags in the head with the new ones, though I'm not even sure if browsers would notice the change. Maybe that doesn't matter though, since having an RSS button in your browser chrome seems to be rapidly disappearing.)

Any thoughts? Or am I doing it wrong?

—
Reply to this email directly or view it on GitHub.

[jdelStrother]

If you like I can try to come up with a patch this weekend for just extracting <script> and <link rel=stylesheet> tags when building the list of assets?

[dhh]

Please do.

On Oct 19, 2012, at 7:49 AM, Jonathan del Strother [email protected] wrote:

If you like I can try to come up with a patch this weekend for just extracting <script> and tags when building the list of assets?

—
Reply to this email directly or view it on GitHub.

[davydotcom]

I discovered this myself, on a blog site I was working with turbolinks on last weekend with regards to rss. I wrote this particular chunk of code and forgot to consider those cases. Blame me for that one :/

[davydotcom]

closable