Giter Site home page Giter Site logo

Comments (10)

judell avatar judell commented on May 26, 2024

When you use tag_dimensions they can also show up in an unexpected order.

Given this setup:

variable "common_dimensions" {
  type        = list(string)
  default     = [ "connection_name", "region" ]
}

variable "tag_dimensions" {
  type        = list(string)
  description = "A list of tags to add as dimensions to each control."
  default     = [ "Name", "Project"]
}

I'm seeing rows like:

Cairo aws_mifflin us-west-2 Linux Test

where:

Cairo is the value of a Project tag

aws_mifflin is a connection name

us-west-2 is (obviously) a region

Linux Test is the value of a Name tag

from powerpipe.

cbruno10 avatar cbruno10 commented on May 26, 2024

@judell Are you seeing the same ordering errors when running steampipe check benchmark.ec2 (along with any other benchmarks you are testing in)?

I couldn't reproduce the ordering issue through the steampipe check command, but through steampipe dashboard I consistently had 2-3 controls with the additional dimensions in different orders.

I thought there may be an issue due to the lack of alias, so the connection name info would come under the ?column? column, but even adding an alias of connection_name in the locals definition didn't appear to fix it.

from powerpipe.

MichaelBurgess avatar MichaelBurgess commented on May 26, 2024

The dashboard UI is using the same logic as the CLI - that is, the order of the non-standard control columns in the results columns are used as the order for the dimensions. In the examples above, the UI is presenting the columns in the order it received them for that control.

Looking into the AWS Thrifty mod it seems like the order should be consistent due to the use of locals to inject them into the queries.

I think we'll need @kaidaguerre to take a look and see why we might be getting different column ordering in the controls sent across the socket to the dashboard UI.

from powerpipe.

github-actions avatar github-actions commented on May 26, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

from powerpipe.

github-actions avatar github-actions commented on May 26, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

from powerpipe.

github-actions avatar github-actions commented on May 26, 2024

This issue was closed because it has been stalled for 90 days with no activity.

from powerpipe.

cbruno10 avatar cbruno10 commented on May 26, 2024

@kaidaguerre Have you had a chance to look at this issue at all? I'm running into the same issue as @judell where I have a few controls in a benchmark that have the same set of additional dimensions in the same order, but when running them in steampipe dashboard, they can come in different orders.

When I run through steampipe check, the order is preserved and consistent though.

from powerpipe.

github-actions avatar github-actions commented on May 26, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

from powerpipe.

github-actions avatar github-actions commented on May 26, 2024

This issue was closed because it has been stalled for 90 days with no activity.

from powerpipe.

github-actions avatar github-actions commented on May 26, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

from powerpipe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.