I18NSession redesign

[turquoiseowl]

I18NSession redesign

[danielcrenna]

It was meant to be an extension point for alternative storage designs, i.e. to use a cookie vs. the default behavior of storing in HttpContext.Session. You're achieving that another way in the 2.0; I'll have to spend more time with your changes to find where the best place is to pivot on storage choices, but there's probably a small list (session, cache, cookie, user's formsauth ticket) unless you have a case to remove this flexibility and embed it somewhere else.

[turquoiseowl]

It would be better to have a choice for that storage as you mention, ideally implemented like ILocalizingService etc.

Not wanting to bang on about names :) but perhaps a further problem I have with I18NSession is that it pre-supposes the storage mechanism.

[danielcrenna]

Yes. At the time I was thinking "session" in the conceptual sense, but
nobody wants to actually use session anymore.

We just need a pluggable storage interface that you can flip in settings or
provide your own like any IoC style lifetime management API.

But if you want to zap that class, go for it.

On Tue, Jan 29, 2013 at 12:53 PM, Martin Connell
[email protected]:

It would be better to have a choice for that storage as you mention,
ideally implemented like ILocalizingService etc.

Not wanting to bang on about names :) but perhaps a further problem I have
with I18NSession is that it pre-supposes the storage mechanism.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-12847967

[turquoiseowl]

In order to zap I18NSession, it would help to first finalize what to do about Basic and Enhanced mode. Zapping Basic mode would help with zapping I18NSession.

The only reason I can think of to not zap Basic is that some will want it's URL/route localization scheme. However, to mitigate that objection, I've added the pivot for it into Enhanced with the IUrlLocalizer interface.

I'd quite like to zap it and so wrap up my contrib for now.

[danielcrenna]

Yes, I think we already decided to remove basic mode, and provide an
equivalent scheme, and use docs to transition users.

On Wed, Jan 30, 2013 at 10:17 PM, Martin Connell
[email protected]:

In order to zap I18NSession, it would help to first finalize what to do
about Basic and Enhanced mode. Zapping Basic mode would help with zapping
I18NSession.

The only reason I can think of to not zap Basic is that some will want
it's URL/route localization scheme. However, to mitigate that objection,
I've added the pivot for it into Enhanced with the IUrlLocalizer interface.

I'd quite like to zap it and so wrap up my contrib for now.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-12925860
.

[turquoiseowl]

Great, its done. About to lop out the IHtmlString / MvcHtmlString pivot interface now which I think is redundant:
http://stackoverflow.com/questions/3382860/htmlstring-vs-mvchtmlstring

[danielcrenna]

+1

On Thu, Jan 31, 2013 at 11:17 AM, Martin Connell
[email protected]:

Great, its done. About to lop out the IHtmlString / MvcHtmlString pivot
interface now which I think is redundant:
http://stackoverflow.com/questions/3382860/htmlstring-vs-mvchtmlstring

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-12950186
.