Comments (8)
Thanks for the report! You are right that window
does not exist in the environment for Web Workers. Maybe we should use self
instead for detecting support: https://developer.mozilla.org/en-US/docs/Web/API/Window/self and https://developer.mozilla.org/en-US/docs/Web/API/WorkerGlobalScope/self
The following code could be a replacement without depending on window
, although I didn't test it yet:
const isSupported = typeof self !== undefined && 'XMLHttpRequest' in self && 'Blob' in self && typeof Blob.prototype.slice === 'function'
Could you try it out and open a PR if it works?
from tus-js-client.
Tested your code and it works fine with worker. The test-node
and test-puppeteer
run just fine.
However, I did not manage to create a specific demo for worker or a specific test for worker.
Here is my PR #660
from tus-js-client.
May I know the status of this? Anything that I need to do on my side?
from tus-js-client.
I didn't have the time yet to try it out but I plan on doing so in the next few days
from tus-js-client.
I would also love to get this merged if it would solve this issue. If any additional help is required, I'm happy to lend a hand.
from tus-js-client.
I added a few more commits to your PR and merged it. Can you please test the latest main branch from GitHub and let me know if it works? If so, I can release a new version.
from tus-js-client.
Tested the main branch locally and works fine using with worker
from tus-js-client.
Thanks for the confirmation! I just published v4.0.1, which includes this patch.
from tus-js-client.
Related Issues (20)
- MIT License HOT 2
- tus-upload large file not working in Ubuntu nginx server HOT 3
- Switch from HTTPS to HTTP Causes Mixed Content Errors HOT 1
- It's not possible to declare onShouldRetry and fallback to the default behaviour HOT 1
- Failed because: Error: tus: unexpected response while uploading chunk, [...] HOT 12
- define a global maximum concurrent request limit HOT 3
- > net::ERR_UPLOAD_FILE_CHANGED
- TypeError: Cannot read properties of undefined (reading 'Upload') HOT 4
- Base64 Encoding of Metadata Assumes Metadata Value is a UTF8 String (Should It?) HOT 6
- RetryDelays: "Type 'null' is not assignable to type 'number[] | undefined'". But null is acceptable. HOT 2
- Replace Karma test runner
- Duplicate calls to `start` cause duplicate uploads
- Can onSuccess return the file address when the upload is successful? HOT 10
- Provide fallback storage when using tus in Web Workers HOT 3
- Either a Bug or i'm doing something wrong HOT 3
- removeFingerprintOnSuccess not working on multiple files HOT 4
- Decrease browser bundle size HOT 1
- Change request method to PATCH HOT 3
- How to set creator, Signed URL and Allowed Origins on Cloudflare TUS Upload HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tus-js-client.