Comments (3)
Thanks @MaximKirsch - yes, good spot. Will address
from tutors.
@edeleastar a little help on the debugging side of it as I get lost in CSS / Svelte :) There wasn't any obvious debugging so I saw in stores.ts that it hardcodes the storeTheme variable to tutors, I made a small change:
let initialTheme = "tutors"; // Default value
export const setInitialTheme = (theme: string) => {
initialTheme = theme;
};
export const storeTheme = localStorageStore("storeTheme", initialTheme);
and I can see the right theme name propagating through. This might have been propogating anyway but I think you should consider such a change in case that hard coding causes issues in user generated apps. Might be totally unnecessary but you know this better than I do.
In icon-lib.ts you have a subscribe to the storeTheme and I can see the right variable name makes it this far. My guess is here you need to do a CSS swaparoo to load the correct theme on the value change. That's as far as my skills will take me, I reckon it's a quick fix though
from tutors.
Thanks @lgriffin - will try this today….
from tutors.
Related Issues (20)
- Redirect on Sign in to course unreliable
- Introduce contribution guidelines
- Support Vercel + GitHub pages deployment
- netlify.toml file research
- Tutors Version Management HOT 2
- TutorsMesssage : move to be read from an external source, perhaps a single use gh-pages repo. HOT 1
- Schema for TutorsTime data store HOT 1
- Abstract analytics service HOT 1
- Supabase Analytics Implementation HOT 1
- Firebase to Supabase migration HOT 1
- Learning objects starting with 'html' are filtered out of course HOT 1
- Dark Mode Text Color in Footer HOT 2
- Search Input Field does not auto-focus on component mount HOT 1
- Old websites that used "archive" folder name rather than "archives" have broken links HOT 1
- Click / Touch Target Too Small on Search Result Cards
- Allow pdf files to either categorised as labs or lectures HOT 1
- Card description
- Images only work in lightmode or in darkmode HOT 1
- topic context navigator in labs HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tutors.