Comments (3)
You are correct it is a bug. It seems I have assumed Headers object is immutable. Thanks for the heads up!
from slim-api-skeleton.
Mika can I ask you a tip to reduce the serialize lines and respective response ie
$app->post("/todos", function ($request, $response, $arguments) {
[...]
/* Serialize the response data. */
$fractal = new Manager();
$fractal->setSerializer(new DataArraySerializer);
$resource = new Collection($todos, new TodoTransformer);
$data = $fractal->createData($resource)->toArray();
return $response->withStatus(200)
->withHeader("Content-Type", "application/json")
->write(json_encode($data, JSON_UNESCAPED_SLASHES | JSON_PRETTY_PRINT));
$app->get("/todos/{uid}", function ($request, $response, $arguments) {
[...]
/* Serialize the response data. */
$fractal = new Manager();
$fractal->setSerializer(new DataArraySerializer);
$resource = new Item($todo, new TodoTransformer);
$data = $fractal->createData($resource)->toArray();
return $response->withStatus(200)
->withHeader("Content-Type", "application/json")
->write(json_encode($data, JSON_UNESCAPED_SLASHES | JSON_PRETTY_PRINT));
Start from todos routes methods, compliting my others API routes like todos with the same functions, I'll write the same serialize with the same response, so I think about "don't repeat yourself" principle and maybe with SLIM design pattern I can improve the code...Is it right use this schema or I'm just complicating myself? If it's worth, how can you rewrite it?
Thanks for your suggestion!
from slim-api-skeleton.
You could extract serializing part to external facade class and it would save a couple of lines in the route. Calling the facade could look something like.
$data = (new SerializerFacade($todo, TodoTransformer::class))->toArray()
Downside is this would make code a bit harder to follow since you have to go see the source of the facade class to understand what is happening. It is always a fine line between optimising and readability.
from slim-api-skeleton.
Related Issues (20)
- how to ignore /user but work with /user/create? HOT 6
- How to pass "--user test:test" in curl options in php HOT 2
- Cache HOT 1
- Missing vendor folder? HOT 1
- Not using the latest version of psr/http-server-middleware? HOT 2
- Fatal error: Uncaught Error: Class 'Slim\Middleware\JwtAuthentication HOT 1
- Zend TableGateway can't execute 2 consecutive query HOT 3
- Read Query Handler returns null HOT 11
- [QUESTION] How to add MySQL ORDER BY HOT 3
- Return value of Tuupola\\Middleware\\CorsMiddleware::origin() must be an instance of Tuupola\\Middleware\\void, none returned HOT 4
- Fractal inside dependencies.php is not used
- How set dynamic database host names
- HttpBasicAuthentication HOT 2
- Too few arguments to function Skeleton\\Domain\\Token: HOT 3
- New version not working after installation ? HOT 1
- Update to Slim 4? HOT 2
- Question: How to deal with insert queries and table joins?
- Invalid Authencation Token
- JWT support HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from slim-api-skeleton.