Comments (14)
from emacspeak.
Would you be willing to merge #55?
If you merge that, then only two libraries remain that are problematic from my perspective.
-
tapestry.el. You previously said that you won't remove that because that would mean that all emacspeak users would have to install vm. I agree that that would be highly undesirable. It also isn't what I was proposing. I was proposing that I would distribute that library as an independent package that both vm and emacspeak would then depend on. However I realize that you might not want to do that either because then all emacspeak users would have to install that package. Is that so?
-
tetris.el. I can live with that as I would just patch it out on the emacsmirror.
from emacspeak.
from emacspeak.
Please take out the creation of .nosearch in tvr/ as I said tvr is my
emacs setup and you or no one else has the right to tell me what I put
there, or block my emacs setup from searching it. Your emacs mirror if
it wants to mirror the distributed emacspeak should follow the make
dist rule in the top-level Makefile as I indicated to you yesterday.
from emacspeak.
Applied PR #55, and removed tvr/.nosearch --- checked in. Thanks for
the patch!
from emacspeak.
Thanks for agreeing to make some of these changes!
from emacspeak.
On tapestry.el
all uses of tapestry.el are constrained to emacspeak-tapestry.el which
defines 2 functions that rest of emacspeak uses.
If we could write these independent of tapestry, we could eliminate
tapestry.el entirely -- want to give me some help doing that?
from emacspeak.
If we could write these independent of tapestry, we could eliminate
tapestry.el entirely -- want to give me some help doing that?
I would be happy to help you with that.
I have already looked into it but have a question before I can continue.
Just copying the needed functions recursively amounts to 74 lines. Removing code that makes sure certain built-in functions before using them reduces this to 40 lines. Fun fact: some of these functions existed for nearly three decades now. Further refactoring could reduce this even further.
Before I know how much I can discard, I need to now whether the order of the list of windows matters, and to what extend. I assume that it should be a somewhat stable order but the exact order is not that important. Or in other words, can we just use window-list instead of tapestry-window-list?
One difference is that window-list begins with the selected window, while tapestry-window-list begins with the window in the top-left corner. We can get the behavior of the latter with the former too, but the order in which the other windows appear is likely different.
from emacspeak.
I have opened the pull-request #56 to demonstrate how we could use the built-in function window-list and completely drop the tapestry library. This is only intended for you to test whether this changes the behavior of emacspeak-tapestry-describe-tapestry. I have not actually removed the library or any of the references to it.
from emacspeak.
from emacspeak.
from emacspeak.
Great! (And yes you were already way ahead.) Thanks again.
from emacspeak.
from emacspeak.
Glad you got something out of it. I agree that getting rid of old code is nice. :-)
from emacspeak.
Related Issues (20)
- Can you independantly alter sound effects volume? HOT 2
- Extremely Slow Speaking (on master using mac) HOT 5
- Deadgrep doesn't read filenames on file-skip (M-n M-p) HOT 1
- macOS speech server extremely buggy on Ventura. HOT 18
- No audio when under cycle-completion-threshold HOT 2
- (investigation) Robot/Buggy Audio after extended use HOT 1
- Invalid function: (PULSE SINK tts-notification-device)
- Make fails. HOT 3
- voxin / outloud - starting outloud server fails, with "no language found" HOT 2
- Remove "automatically exported from code.google…" from the repo description
- Is contributing to manual still requries sending an email? HOT 2
- In absence of DTK_PROGRAM Emacs shortcuts are broken and no indication of the problem HOT 2
- Scripts and shebangs
- Cannot configure automatic language switching in multispeech server to work with emacspeak HOT 5
- chrome_tts_server no longer works with modern chrome HOT 6
- Cannot reproduce the audio examples on a Ubuntu 2204 Gnome Desktop with Google Chrome HOT 2
- [Feature Request] Make RHVoice compatibility HOT 3
- system-sounds works, but no input from `piper` HOT 1
- Why do I get void-function ems-generate-switcher? HOT 1
- Why do I get relocation R_X86_64_32 against `.rodata' can not be used when making a shared object?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from emacspeak.