XP11/Mac: After failed init of LT, XP crashes some time later

[twinfan]

XP11/Mac: After failed init of LT, XP crashes some time later

[TwinFan]

Check if same occurs with completely empty plugin, which just returns 0. If so -> file bug with Laminar

[TwinFan]

Checked with Hello World Plugin...if that just returns 0 everything else works just fine. So it is a LiveTraffic issue I'm afraid.

Fetching plugins for /Users/birger/Applications/X-Plane 11/Resources/plugins

Loaded: /Users/birger/Applications/X-Plane 11/Resources/plugins/PluginAdmin/mac.xpl (xpsdk.examples.pluginadmin).

Failed: /Users/birger/Applications/X-Plane 11/Resources/plugins/Hello-World-SDK-3.xpl. (The plugin refused to start by returning 0 from XPluginStart.)

Loaded: /Users/birger/Applications/X-Plane 11/Resources/plugins/DataRefEditor/mac.xpl (xplanesdk.examples.DataRefEditor).

Found stats plugin: 2
I found the following scenery packages (prioritized in this order):
  0 Custom Scenery/yOrtho4XP_Overlays/
  1 Custom Scenery/zOrtho4XP_+27+089/

Idea: Check for static variables, which will be initialised and what they might change.

[TwinFan]

Reason was that along the way of initialization SHOW_MSG was called, which had called XPLMCreateWindowEx to create the window for the message area. Apparently, X-Plane doesn't clean up window handles if the plugin returns 0 from XPluginStart.
Now we call DestroyWindow() before returning 0 from XPluginStart and the crash has gone.

[TwinFan]

User reports crash after startup failed with LiveTraffic not loading the config file:

LiveTraffic: LiveTraffic 1.22.190829 starting up...
LiveTraffic 1575146591.5 ERROR src\DataRefs.cpp:1611/LoadConfigFile: Config file 'D:\Program Files (x86)/Steam/steamapps/common/X-Plane 11/Output/preferences/LiveTraffic.prf' first line: Unsupported format or version:
Failed: D:\Program Files (x86)/Steam/steamapps/common/X-Plane 11/Resources/plugins/LiveTraffic/64/win.xpl. (The plugin refused to start by returning 0 from XPluginStart.)

(Workaround is to remove the preferences file to make LiveTraffic create a new one.)

[TwinFan]

Culprit was a call to XPLMRegisterFlightLoopCallback. This is now delayed to the XPluginEnable function. Together with another fix this also fixes the long-known never anylzed issue, that the plugin didn't auto-start after disabled and re-enabling in the plugin admin.