Traceback when browsing static dir

[twisted]

Traceback when browsing static dir

[dreid]

Oh nice catch. I'll fix that.

[oubiwann]

Sweet! Thanks :-)

[iffy]

Oh, hey, you're already aware of the problem. I started writing a test to fix it, but I'm running into Mock problems. My work is in https://github.com/iffy/klein/tree/fix-static

[dreid]

Yeah, upon investigation I ran into a similar problem with the tests.

requestMock should really be returning an actual Request(DummyChannel(), False) that has been configured appropriately.

Klein's implementation of branches should probably also make use of the fact that twisted.web.server.Request is Componetized instead of just patching an attribute on it.

An IKleinRequest could be used to keep track of the extra information and the code to handle branches would do IKleinRequest(request).branch_segments to get at the branch segments.

[jlujan]

So is this solved?

[dreid]

Here is a branch which appears to fix this behaviour: https://github.com/twisted/klein/tree/real-request-tests