Can't Compile finagle-zipkin

[twitter]

Can't Compile finagle-zipkin

[johanoskarsson]

Hey @mosesn,

First off, thanks for looking into Zipkin.

I'm not sure I get what you're trying to do. Is there a reason the original build files (Project.scala, build.sbt and plugins.sbt) don't work for you?

[mosesn]

I'm trying to compile just finagle-zipkin, so that I can include it in another project like so:

libraryDependencies += "com.twitter" %% "finagle-zipkin" "1.0-SNAPSHOT"

and then fetch it from my local repository. If I try to publish-local using the original build files, I get all of finagle in my local repo, which is not what I want. Also, the reason I am trying to publish-local in the first place instead of fetching from twttr is that I ran into problems with compatibility that I'm betting are because finagle-zipkin isn't cross-compiled on twttr.

[johanoskarsson]

Aha, I see. Are there parts of finagle-zipkin you need but you don't need finagle-core and finagle-thrift? If there's a good reason to split that up further to make it easier we can consider it. For finagle-zipkin as a whole to function it needs finagle-thrift in order to send the data to the Zipkin collectors.

[mosesn]

I am working with a slightly hacked version of finagle that is current up to 3.0.0. Since the API for finagle hasn't changed since then, it seemed like it would be fine as long as I compiled it to the same version of scala. The only problem is that finagle-zipkin didn't exist back in the day.

[johanoskarsson]

I can't remember exact versions but it's possible that it was called finagle-b3 back then. It's basically the same, we had to rename the project before open sourcing Zipkin.

[mosesn]

are you saying that I can find a ZipkinTracer in finagle-b3?

[johanoskarsson]

You can find the equivalent in there. finagle-b3 has something called BigBrotherBirdTracer, that was the name for ZipkinTracer before. It might have some small differences though, such as it uses a different Scribe category. I assume it's not possible for you to contribute your Finagle changes and upgrade to the latest version?

[mosesn]

I don't know what all of the changes are, I'll talk to someone who does and see what's up. In the mean time, do you know why I can't find scribe.ServiceToClient? It seems to be something that your thrift can do, based on #45, but it can't be done with scrooge, as far as I can tell.

[johanoskarsson]

I believe that stuff is part of the generated code that sbt-thrift creates.

[mosesn]

Is sbt-thrift compatible with build.sbt?

[johanoskarsson]

To be honest I don't know. I think it might be easier to just use finagle-b3 until you upgrade and either change the category there or just change the zipkin collector config to allow the b3 collector: var categories: Set[String] = Set("b3") or similar.

[mosesn]

Alright, good to know. I'm working on getting us upgraded to what's current, so probably at least one of these will pan out. Thanks for the help!