[Suggestion] Exceptions extending HttpException

[tymondesigns]

[Suggestion] Exceptions extending HttpException

[tymondesigns]

Hi Felix,

I definately like the idea of having the status code within the exception. Although I think it would be better to implement this without symfony's help. Since I would only be using a very small portion of the http-kernel package.

I will add the ability to access the status code in the same way that symfony does:
$exception->getStatusCode();

My plan is to try and get this package to not depend on Laravel (although Laravel setup will remain seamless).

I will let you know how it goes.

Thanks!

[pulkitjalan]

I needed this also, done a pull request #17

Please can you have a look when you get some time.

[tymondesigns]

Thanks, #17 merged.

@felnne any thoughts ?

[felnne]

Annoyingly that won't work for my use case, (using the JSON Exception Formatter package) as it only calls getStatusCode() if the exception is an instance of HttpExceptionInterface (see here).

Arguably that's an assumption on that package's part, and I accept (and agree) with your point about the full HttpException being overkill just to set a status code. However from a practical standpoint, if you're using this with Laravel you would already have this dependency.

Since my use case is focused on a specific combination of circumstances, I am happy to close this issue since the changes added do satisfy my general need, and I can adapt my exceptions to just pass through the status code. I would also probably open an issue with the other package and see if there's some way of relaxing the limitation of checking for a specific exception type.

Thanks again.

[tymondesigns]

Agreed it's a little presumptious on that packages' end... Closing for now, although I might reconsider down the line