Giter Site home page Giter Site logo

Comments (3)

tymondesigns avatar tymondesigns commented on May 8, 2024

just noticed this after commenting on #59

Yea, you are right about $app->make() not needing an explicit param.
That being said, I think I will do it like this in the next release: (like dingo/api does it)

// in config.php
'auth' => function ($app) {
    return new Tymon\JWTAuth\Providers\Auth\IlluminateAuthAdapter($app['auth']);
}

and then in the service provider use something like this method to get the instance

thoughts?

from jwt-auth.

hackel avatar hackel commented on May 8, 2024

That would definitely work too. In my mind using type-hinted dependency injection is simpler, but this is probably more flexible.

from jwt-auth.

tymondesigns avatar tymondesigns commented on May 8, 2024

this is done, as of 0.5.1 :)

from jwt-auth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.