Ignore extension methods

[paiv]

Ignore extension methods

[andrewchang-bird]

What’s the primary concern against generating mocks for extended methods / variables?

[paiv]

I have no followup

[paiv]

I wanted to test implementation of extension method:

Protocol:

protocol First {
    func greet(_ name: String)
}

extension First {
    func greetGuests() {
        greet("guests")
    }
}

Test:

import Mockingbird
import XCTest
@testable import Sample


class FirstTests: XCTestCase {
    
    func testGreet() {
        let first = mock(First.self)
        
        first.greetGuests() as Void
        
        verify(first.greet("guests")).wasCalled()
// failed - Incorrect total invocations of ``greet`(_ name: String) -> Void` matching (guests)
    }
}

[paiv]

Second, this generated code doesn't look right to me:

  public func `greetGuests`() -> Void {
    let invocation: Mockingbird.Invocation = Mockingbird.Invocation(selectorName: "`greetGuests`() -> Void", arguments: [])
    mockingContext.didInvoke(invocation)
    let implementation = stubbingContext.implementation(for: invocation, optional: true)
    if let concreteImplementation = implementation as? () -> Void {
      concreteImplementation()
    } else {
      (implementation as? () -> Void)?()
// if the cast failed on the `if let` line, casting it again to the same type surely will fail again, resulting in a nil call
    }
  }

[paiv]

I can get the test passing with this change:

    func testGreet() {
        let first = mock(First.self)
        
        (first as First).greetGuests()
        
        verify(first.greet("guests")).wasCalled()
    }

So I guess this works as intended.