Giter Site home page Giter Site logo

Comments (4)

DennisTsar avatar DennisTsar commented on June 12, 2024 1

Thanks! I am good with waiting until the next release. By the way, it seems that gradle/gradle-build-action has been replaced by gradle/actions/setup-gradle per the README, so it may be worth migrating the action.

from github-workflows-kt.

krzema12 avatar krzema12 commented on June 12, 2024

You're right!
The source of this typing is here:
https://github.com/typesafegithub/github-actions-typing-catalog/blob/65d9210c41baf7302896cadbfb65bdcc5f1c189e/typings/gradle/gradle-build-action/v3/action-types.yml#L65-L66

I agree it should be a string. It acts like user's declaration, so we should them type anything and let the action validate the input.
@DennisTsar would you like to contribute to the typing catalog and fix the typing there?

from github-workflows-kt.

krzema12 avatar krzema12 commented on June 12, 2024

@DennisTsar fixed on the main branch. Do you need the fix ASAP or can we wait till the next release (in a week)?

from github-workflows-kt.

krzema12 avatar krzema12 commented on June 12, 2024

Good idea, here's a task: #1271

from github-workflows-kt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.