Comments (4)
I like this aproach.
This would be a breaking change ... to prevent problems with existing uses of dts-bundle I would keep the behaivor when out
parameter don't starts with slash ("/"). But I would change the behaivor when out
parameter start with slash.
Then, with out: /dist/si-portal-framework.d.ts
the final path must be C:\dev\S-Innovations\S-Innovations.PortalFramework\src\dist\si-portal-framework.d.ts
and with out: dist/si-portal-framework.d.ts
the final path will continue being C:\dev\S-Innovations\S-Innovations.PortalFramework\src\artifacts\dev\dist\si-portal-framework.d.ts
.
If anyone says otherwise, I think it would be good.
from dts-bundle.
Working on it:
// Calculate out file path (see #26 https://github.com/TypeStrong/dts-bundle/issues/26)
function calcOutFilePath(out: any, baseDir: any) {
var result = path.resolve(baseDir, out);
// if path is absolute and start with "/" and not is a net route ("//") resolve from local
if (path.isAbsolute(out)
&& stringStartsWith(out, path.sep)
&& !stringStartsWith(out, `${path.sep + path.sep}`)) {
result = path.resolve(".", out.substr(1));
}
return result;
}
When the path is absolute and start with slash and not is a net route resolve with the current path.
from dts-bundle.
Fail to pass tests on travis.
I had tested it on windows where local absolute paths starts with "C:" ... but in linux the absolute paths starts with "/" then no way to determinate if you want absolute path or relative to current path.
I have added the possibility of pass out
parameter starting with "~", this way:
// Calculate out file path (see #26 https://github.com/TypeStrong/dts-bundle/issues/26)
function calcOutFilePath(out: any, baseDir: any) {
var result = path.resolve(baseDir, out);
// if path start with ~, out parameter is relative from current dir
if (out[0] === "~") {
result = path.resolve(".", out.substr(1));
}
return result;
}
If test passed I will approve it..
from dts-bundle.
The out parameter have to start with "~/".
Final code:
// Calculate out file path (see #26 https://github.com/TypeStrong/dts-bundle/issues/26)
function calcOutFilePath(out: any, baseDir: any) {
var result = path.resolve(baseDir, out);
// if path start with ~, out parameter is relative from current dir
if (stringStartsWith(out, "~" + path.sep)) {
result = path.resolve(".", out.substr(2));
}
return result;
}
from dts-bundle.
Related Issues (20)
- file not found error if both .d.ts file and a folder with the same name exist HOT 8
- removeSource option deletes .d.ts files within node modules HOT 3
- Export as default edge case
- A 'declare' modifier is required for a top level declaration in a .d.ts file. HOT 4
- Unable to reference external typings HOT 2
- Duplicated imports after bundle into single .d.ts file HOT 3
- Reexporting module as named export for module library HOT 4
- bug? declare module 'yargs2/index//yargs' HOT 2
- Bundle includes more than it should when using main
- dts-bundle generates circular dependencies HOT 1
- fs.writeFileSync passes the encoding the wrong way
- tsconfig.json paths HOT 2
- Add support to export as namespace HOT 1
- "already got export for:"
- All d.ts files bug with scoped package
- Interfaces with same name in separate files are combined
- Bundler fails for all declarations if project name contains slash HOT 1
- Declaration for style files
- Relative import error with namespace
- Project seems dead. dts-bundle-generator looks like an alternative.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dts-bundle.