Giter Site home page Giter Site logo

Comments (6)

b-sharpe avatar b-sharpe commented on June 15, 2024

+1
We deploy to prod as part of a CI process and can't currently do this with prod:deploy

from acquia_cli.

typhonius avatar typhonius commented on June 15, 2024

Hi @b-sharpe, I spent a little bit of time on this today and slotted in a fairly simple fix to address this. Could I ask that you look into the auto-confirm branch and the --yes option to add to commands typically requiring a confirmation. It looks ok to me but I'd appreciate a second opinion prior to merging to master.

from acquia_cli.

b-sharpe avatar b-sharpe commented on June 15, 2024

@typhonius awesome, thanks. Seems to work, is there (or possibly in future) ever a case where the 'yes' option wouldn't exist? I notice getOption throws an exception if there is no definition for yes

Otherwise, it works and i'm all for it! (would love to get a release with this as well as the optional config steps) :)

from acquia_cli.

typhonius avatar typhonius commented on June 15, 2024

@b-sharpe as long as the option is defined (which we do in src/AcquiaCli.php) then getOption won't throw the exception. Since we're adding in this option, we have control over if we'll ever remove it (which I can't see me doing). On reflection of your comment, we could potentially rename --yes to something a bit more specific e.g. --no-confirm. Do you have any ideas about a relevant command option?

from acquia_cli.

b-sharpe avatar b-sharpe commented on June 15, 2024

no I think --yes and -y are pretty universal in the drupal/drush world, I would keep as is, also agree if you are defining it as a default option that no need to worry about the exception. Good work!

from acquia_cli.

typhonius avatar typhonius commented on June 15, 2024

Thanks - this has been committed, and I've rolled a 1.0.3 version.

from acquia_cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.