Giter Site home page Giter Site logo

Expensive health-check about quickchart HOT 5 CLOSED

typpo avatar typpo commented on August 15, 2024
Expensive health-check

from quickchart.

Comments (5)

mcobzarenco avatar mcobzarenco commented on August 15, 2024

Happy to change the current health-check and submit a PR unless there's a good reason why it's expensive. Thanks!

from quickchart.

typpo avatar typpo commented on August 15, 2024

Hi Marius, thanks for the feedback. The reasons why I created an endpoint that actually renders a chart:

  1. The service runs behind Cloudflare and I wanted a healthcheck that could not be cached (hence the random chart)

  2. I wanted the health check to ensure that chart rendering was working properly. I was worried about some state (e.g. high CPU usage) in which the server might be responsive but chart rendering was slowed.

To save you some trouble, I've changed /healthcheck to be lightweight and moved the previous "random chart" endpoint to /healthcheck/chart, so it should now be good for your purposes!

Planning to update the README with more info on health and monitoring...

from quickchart.

mcobzarenco avatar mcobzarenco commented on August 15, 2024

Wow, @typpo that was quick! Makes a lot of sense, thanks.

from quickchart.

mcobzarenco avatar mcobzarenco commented on August 15, 2024

Also -- just wanted to say -- really useful library!

from quickchart.

typpo avatar typpo commented on August 15, 2024

Thanks! Just a heads up, the public Docker build is not updated automatically. That will be done shortly in case you are using it.

from quickchart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.