Comments (18)
Unfortunately, that would break a lot of code for many people. Doesn't seem to be an option. Closing as wontfix.
from uap-core.
that would break a lot of code for many people.
Why?
from uap-core.
Well, because a lot of people might be relying on where the implementation actually is right now. Even if redirects were to work perfectly for all cases (which I find highly doubtful), this would imply keeping a reference to all lang ports in this repo which defeats the purpose.
from uap-core.
a lot of people might be relying on where the implementation actually is right now.
Not a problem, fully, perfectly and silently redirected.
which I find highly doubtful
Don't! 😄
See: https://github.com/benben/ofxAddonTemplate which redirect to https://github.com/openframeworks/ofxAddonTemplate
Raw are quite well managed with internal redirection (it avoid redirection error in scripts) (eg: https://raw.githubusercontent.com/benben/ofxAddonTemplate/6edfe989475e0171d3c1b1b71de4022d790621ea/README.md)
Ref: https://help.github.com/articles/transferring-a-repository/#redirects-and-git-remotes
would imply keeping a reference to all lang ports
Why so?
from uap-core.
would imply keeping a reference to all lang ports
Why so?
Because what's the point of redirecting if its to end up on a missing dir?
from uap-core.
Redirecting is only so important for the data (i.e. regexes.yaml
, etc).
Actually, all other port folders are now splitted in their own repository, then each language port changes should be managed by their own package manager (and this is a good thing for coherence).
So these old folders should be no more present in the core repository.
At the end you will got a core repository like this one (https://github.com/ua-parser/uap-core) (the same in fact) but with all data (stars, forks, link point to, etc) kept.
from uap-core.
So it might be a good idea to do that once we've completely migrated all packages. At which point we'd be loosing a lof of history/issues here. Don't think it's worth it atm.
from uap-core.
At which point we'd be loosing a lof of history/issues/here
Not sure what you mean, but it could be a super another argument to transfer: all issues/pr are transferred into the the "new" repo, then you will not loose them.
atm
? (sorry, I'm not a native English...)
from uap-core.
What I'm trying to say is:
- we're not doing that now because we'd break a lot of code
- we're not doing that in the future because at that point we'd be loosing history + issues in the current repository.
from uap-core.
I don't understand your point of view:
- You're not going to break code by doing this (everything is perfectly managed and structured)
- You're not going to loose history and issues (_everything_ is transferred with the transfer)
from uap-core.
We're going on in circles at this point.
- You're suggesting we redirect the existing repo here but then remove all the lang ports from it. So that is obviously going to break things. For example, what if someone is relying on the php dir to be in the repo for whatever reason that is?
- I'd feel fine doing that at a latter stage (once everything is up and running here), but if we do that later, then we'd be loosing the history/issues created on this repo in the meantime, which would also suck.
I appreciate that you disagree with this. But there are tradeoffs to be made in every migration of this sort, and I want to favor not breaking stuff over transferring history and issues.
from uap-core.
We're going on in circles at this point.
That's true. 😄
My last comment.
For example, what if someone is relying on the php dir to be in the repo for whatever reason that is?
Because you will keep all of these port folders in your global repo?!
Then you can delete organization right now, it will be to hard to maintain all repo synced and coherent, you will not loose the history but your time!
With ❤️
from uap-core.
I have no idea what you're talking about at this point. :(
from uap-core.
Maybe it would be good to talk through user scenarios here instead of using
terms like "global repo". I think there's a little lang usage bug and
perhaps you guys are saying the same thing (though I don't think so).
e.g:
what does the repo look like on day 1?
what happens when someone tries to access a particular url?
On Mon, Nov 10, 2014 at 12:57 PM, Tobie Langel [email protected]
wrote:
I have no idea what you're talking about at this point. :(
—
Reply to this email directly or view it on GitHub
#3 (comment).
from uap-core.
Given there seems to be language issues involved, and that we both speak french, please reach out by email (my address is on my profile). I tried to mail you directly but couldn't find your email address and about.me is down right now. I'll prune the above thread as it's just confusing to anyone who would want to follow.
from uap-core.
please reach out by email
Right.
from uap-core.
OK, so @LeoColomb and I talked this over on email and there's now agreement that transferring the repository of my account comes with a lot of risks and brokenness and buys us very little. It might be however fun to see if we can save some of the history of the test and regex files into the new repo.
from uap-core.
@tobie Something like this? https://github.com/LeoColomb/ua-parser
from uap-core.
Related Issues (20)
- Add device type
- Support for ua-reduction, do not provide 'detailed' info from 'reduction' strings
- Generic Computer instead of Other
- Recognizing Edge
- [request] add simplified browser name
- Bytespider not recognized as bot
- Question: categorizing headless browsers as spiders?
- Broken test case(s) when implementing `patch_minor` in user agent parser? HOT 1
- User-agent with CriOS mapped wrongly HOT 1
- User-agent with EdgiOS mapped wrongly HOT 1
- [Request] Add support for VivoBrowser and HiBrowser
- OS varies depending on User-agent HTML encoding
- user-agent mapped wrongly HOT 1
- URL in code comment points to unrelated website HOT 1
- Uncaught count error from CodeGenerator because of null value in regexes HOT 1
- Spiders catch-all isn't catching spiders with longer user agent strings
- Improve detection for certain browsers
- Actually document the `regex` dialect and semantics
- Specify and regularise non-functional bounded repetitions
- add uap-varnish
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uap-core.