Third party library or framework integration plan

[ua-parser]

Third party library or framework integration plan

[heowc]

I made a simple sample using this.

See https://github.com/heowc-scratch/spring-uap_java

[bpossolo]

What kind of Spring integration are you thinking?

[bpossolo]

I see. So you added method argument resolvers. That’s clever however I wouldn’t recommend doing this because the user agent string will be parsed/evaluated for every single argument that is resolved.

this will impact the performance of your web app because parsing/evaluating the user agent string is expensive (it is compared against every regexp in the yaml file).

I’d recommend having a web filter which parses the user agent string once then adds the result (the Client object) to the RequestContext.

this ensures it is only evaluated once per inbound web request.

With regards to adding support for such a thing to this project... I would prefer not to add dependencies on Spring since many applications don’t use Spring (for example one of my main projects uses PlayFramework instead of Spring MVC).

I could see a side project specifically for spring+uapjava being useful though. Unfortunately I don’t really have enough time to maintain it and Spring publishes new versions pretty frequently so it would be difficult to keep current.

[bpossolo]

Maybe an intermediary solution would be to have a wiki page with integration instructions for the different web frameworks like SpringMVC, PlayFramework, etc.

that could be instructional without being too prescriptive about implementation

[heowc]

That’s clever however I wouldn’t recommend doing this because the user agent string will be parsed/evaluated for every single argument that is resolved.

I agree. Since this is a simple sample, you can try to improve it.

I would prefer not to add dependencies on Spring since many applications don’t use Spring

Oh... it's a new fact. Most of us use the spring framework 🤣

I could see a side project specifically for spring+uapjava being useful though. Unfortunately I don’t really have enough time to maintain it and Spring publishes new versions pretty frequently so it would be difficult to keep current.

I see... That's very unfortunate news. 😂

Maybe an intermediary solution would be to have a wiki page with integration instructions for the different web frameworks like SpringMVC, PlayFramework, etc.

I think this is a useful solution. 👍👍

Thanks for the many comments. 👍