The combination of JSpecify + Lombok does not seem to work well

[kjim]

The combination of JSpecify + Lombok does not seem to work well

[cpovirk]

Thanks for the report and the fix.

As for @NullMarked and @NullUnmarked: My read is that Lombok's lists are for copying annotations from fields only. If so, then we wouldn't have reason to list those annotations, as they aren't applicable to fields (only to methods/classes/packages/modules).

[kjim]

Thanks for the info. I tried your suggestion on https://github.com/kjim/nullaway-example/pull/1/files and the issue has been gone.

In my case, simply adding the following one settings seems to solve the problem (since I don’t use @NonNull).

lombok.copyableAnnotations+=org.jspecify.annotations.Nullable

This workaround seems to work well. Until jspecify annotation is added (or changed?) on lombok side, I can proceed with the migration by adding this setting. Thanks!

[msridhar]

I opened a PR to fix this upstream in Lombok: projectlombok/lombok#3613

[msridhar]

Fixed upstream in projectlombok/lombok#3608

[msridhar]

Thanks for this report! This is not intentional behavior; it's quite surprising in fact. Let me dig a bit to see if I can fix.

[msridhar]

Based on projectlombok/lombok#3346 I figured out the right config required here:

lombok.copyableAnnotations+=org.jspecify.annotations.NonNull
lombok.copyableAnnotations+=org.jspecify.annotations.Nullable

If you want Lombok to use JSpecify annotations for generated code you can also do:

lombok.addNullAnnotations = CUSTOM:TYPE_USE:org.jspecify.annotations.NonNull:org.jspecify.annotations.Nullable

To avoid needing any extra config, I think these two lines in Lombok need to be updated to use the latest JSpecify package names and to refer to @NonNull instead of @NullnessUnspecified:

https://github.com/projectlombok/lombok/blob/8bea25107de8177596546574c02ed204366e1281/src/core/lombok/core/handlers/HandlerUtil.java#L188-L189

(@cpovirk should @NullMarked / @NullUnmarked be in that list as well?)

In any case, let me know if the above config works for you. I'll leave this issue open until we can open an appropriate PR / issue on Lombok.