Giter Site home page Giter Site logo

Comments (7)

miselico avatar miselico commented on August 11, 2024 2

@pminervini @sbonner0 I am currently working on the query generation for more complex queries and other datasets. It is working for our specific setting, but I want to generalize it a bit and separate it from the rest of the codebase.

from cqd.

pminervini avatar pminervini commented on August 11, 2024 1

@pminervini just to dig a little more into the second point - so given the ComplEx embeddings are pre-trained, there is no real concept of training data for the beam search based approach

That's correct!

from cqd.

pminervini avatar pminervini commented on August 11, 2024

Hi! Sorry for the super late reply -- @dfdazac has some code for that I think! Daniel, can you point @sboonner0 to it?

More recently we reimplemented CQD in @hyren et al.'s https://github.com/snap-stanford/KGReasoning/: snap-stanford/KGReasoning#9 -- for analysing the intermediate variable assignments it should be enough to check their values in discrete.py: https://github.com/pminervini/KGReasoning/blob/main/cqd/discrete.py#L36

from cqd.

sbonner0 avatar sbonner0 commented on August 11, 2024

Hi @pminervini - no problem, thanks so much for getting back to me. Thanks for the pointers to the KGReasoning repo, i'll check it out.

I actually have two more questions if that is ok.

  1. Do you have any plans to demonstrate how the approach could be run of a different datasets, including data preprocessing etc.
  2. In trying to understand the beam search approach you discuss in the paper, am I right in thinking that there are no trainable parameters used in this?

from cqd.

pminervini avatar pminervini commented on August 11, 2024

Hi @sbonner0, @dfdazac is looking into merging the code for explanations in this repo!

About your questions:

  1. At the moment we are using the datasets available in https://github.com/snap-stanford/KGReasoning/ -- we haven't looked into generating our own evaluation data yet, but that's definitely on the TODO list (e.g. it could be interesting to analyse the behaviour of the model on way more complex queries).

  2. Yes! It uses an off-the-shelf ComplEx-N3 model trained on 1p queries, and there are no additional trainable parameters. It could be fun to explore models with additional trainable parameters trained on complex queries (rather than just 1p/atomic ones), e.g. for learning parametric t-norms -- let us know if you plan to look into this :)

from cqd.

sbonner0 avatar sbonner0 commented on August 11, 2024

Thanks @pminervini @miselico I look forward to hopefully being able to run your approach on other benchmark datasets such as WN18RR as well as getting some explanations.

@pminervini just to dig a little more into the second point - so given the ComplEx embeddings are pre-trained, there is no real concept of training data for the beam search based approach - or am I missing something entirely?

from cqd.

dfdazac avatar dfdazac commented on August 11, 2024

@sbonner0 thanks for opening this issue initially. I have merged some code in main and an explanation in the README regarding how to generate the explanations. The idea essentially consists of mapping the IDs of the top-k selected entities at each step to their actual name string, and then formatting everything nicely.

from cqd.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.