Comments (2)
fun is asynchronous. Without awaiting it before calling the delay function that restores native time, there is a chance that native time would be restored temporarily while the code in fun is running. You could encounter a similar issue if you were to call ft.restore()
after fun without awaiting it.
from mock.
I realize how it works, but my intent was to point out that someone using the library may not immediately figure out that delay
/restoreFor
has such a side effect. Whether this needs a fix, the choice is yours.
from mock.
Related Issues (20)
- stub function instead of object HOT 1
- Stub should work on non function properties HOT 1
- Simplify restoring all functions for a test HOT 1
- Design and implement a mock for fetch
- (FakeTimer): No way to sense microtasks like sinonjs/fake-timers HOT 8
- Add runMicrotasks to FakeTime
- Add tickAsync
- Replace any with unknown
- Stubbing fetch fails after upgrade to v0.12.0 HOT 6
- Allow Iterable to be passed to resolvesNext
- Allow resolvesNext to continue after rejections in an array
- Fix time type error with dom lib compiler options HOT 1
- export ExpectedSpyCall from mod.ts
- Stop spy and stub working for non function values
- Remove assertPassthrough HOT 1
- How to stub Deno namespace HOT 5
- Request for a new release with the mod.ts file HOT 2
- Improve test coverage for time.ts HOT 1
- Does not compile with Deno 1.6.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mock.