Allow to add extra params to callback_url

[radzserg]

Allow to add extra params to callback_url

[dotdotdotpaul]

I was trying to figure this out as a way to handle redirecting the user when they come back from the auth -- I figured I could pass the referer [sic] as an option to the callback URL and then when they come back, after success, I could send them back "where they came from".

It seems like this use case (redirect to where the login originated) would be a pretty frequently desired result -- am I missing something in the current implementation that already does this?

[terencechow]

@radzserg @dotdotdotpaul

How are you guys handling this currently? I believe I have a similar use case. I have users which have subscriptions and each subscription can have many authorizations. On an auth callback, I have no idea which subscription has made the the authorization and cannot add the association to my db.

Passing a query param to the request url would solve this. Either that or making the request_path understand params such as subscriptions/:subscription_id/auth/facebook

**Edit: ** Decided to go the query_param route and add a plug that puts my query into a session and removes that immediately after the callback. Doesn't feel right but it works...

[dotdotdotpaul]

My current hack is that my login URL is now auth/login/:provider, and that shoves the referer into the session, then redirects to auth/:provider to let Ueberauth work as usual. Then I added to the callback function code that checks the session for the referer, removes it from the session and then redirects (defaulting to "home" if not found). Works fine, if your user is using cookies -- but I figure if someone isn't using cookies, the login isn't going to work particularly well anyway.

[doomspork]

@radzserg I haven't personally had a need for this functionality but there is quite a bit of interest, would you be interested in submitting a pull request for review?

[radzserg]

@doomspork I will. Give me 2 weeks. Completely busy this week.

[radzserg]

I prepared pull request
#45