Giter Site home page Giter Site logo

Comments (2)

piszczu4 avatar piszczu4 commented on June 15, 2024

The same issue appear in the official Tiptap example here - try to click link item. I tried to resolve it using content state and below tippy prop to put that content when closing tippy (and when shouldShow return false) but really looking for some official fix

     onHide: (instance) => {
          setContent(instance.popper.innerHTML);
        },

EDIT
I debug the code and I observed the following: The first time shouldShow is called by onSelectionChange as below:
image

Here, the selection is actually the same on both editor.state and state object so that's not an issue. Because shouldShow (correctly) returns true, Bubbe Menu is showed. Unfortunately, the content of BubbleMenu is created after this shouldShow so the link attributes are empty, hence the href is empty and it does not look good. Its updated later as below

image

Would appreciate any comment from developers and other users

from tiptap.

piszczu4 avatar piszczu4 commented on June 15, 2024

Another issue is that the bubble menu (despite arrow) does not position correctly on first click and you have to click again to position it correctly.

from tiptap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.