Would a PR to change print statements to logging.debug be accepted?

[jcassee]

Would a PR to change print statements to logging.debug be accepted?

[Gldkslfmsd]

OK, go on. I noticed that faster-whisper uses it https://github.com/SYSTRAN/faster-whisper?tab=readme-ov-file#logging , so let's do the same.

[Gldkslfmsd]

Hi, thanks for question.
What is TUI application?
In principle -- I don't know. Let's analyze pros and cons. I don't want to make the code complicated, but I want it to be universal, usable by many people (= not interfering with common tools), and easily maintainable by me.

Can you show me an example how the usage of logging object could look like? E.g. link to another repo, or documentation?

[jcassee]

A TUI is a terminal user interface. I use Textual.

My change would basically replace print functions with logging.info (that's just my suggested level) and remove the logfile attribute from ASRBase. People who want to hide, divert, etc. the logging output can just use logging.basicConfig (as whisper_online_server.py already does).

Of course, this is a backward-incompatible change. However, I think the standard Python logging library is a better (not to mention standard 🙂 ) mechanism. I would be afraid you would reinvent/reimplement other logging features over time.

[jcassee]

I created a PR here: #76