Support for custom document properties in PDFs?

[uglytoad]

Support for custom document properties in PDFs?

[EliotJones]

That sounds like a good addition to the API, it would be fairly easy to add by providing access to the underlying DictionaryToken in the DocumentInformation object. I'll look into adding it when I get time.

[EliotJones]

This is in the latest master code now, it might be worth testing it out for your documents if you're able, I don't have any documents with custom info at the moment to test against. It should make it into the 0.0.7 release for which the timeline is "hopefully soonish".

[Numpsy]

Thanks, i'll give it a test tommorow.

[Numpsy]

Ok, I started adding a unit test @ Numpsy@db0f1c7, and i'm not sure if I've got another issue there.

The 'custom-properties.pdf' file attached to that commit contains multiple sets of document information, which have a few differences in the property values.
If I open the file in Firefox, it shows the Keywords property as being 'MoreKeywords' (which is what I was expecting), but when loading in PdfPig the value in Document.Information is 'TestKeywords', which is an old/previous value.

Possibly something else going wrong somewhere?

[EliotJones]

Thanks for the further bug report, I've pushed some changes which seem to work for this document (and not break the tests!). Let me know if you run into any more issues please, I think the code in that area needs a bit of a rewrite/tidy-up.

[Numpsy]

Ok, that seems to work now, thanks.

Would you be interested in a PR for Numpsy@10dcbd0 to add a unit test?

[EliotJones]

Yes, thank you, that would be good to cover with a test.

…

________________________________ From: Richard Webb <[email protected]> Sent: Saturday, July 6, 2019 10:20:50 PM To: UglyToad/PdfPig Cc: Eliot Jones; Comment Subject: Re: [UglyToad/PdfPig] Support for custom document properties in PDFs? (#38) Ok, that seems to work now, thanks. Would you be interested in a PR for Numpsy@10dcbd0<Numpsy@10dcbd0> to add a unit test? — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#38?email_source=notifications&email_token=AB37QSV74OB2HF5IFYJWWBDP6EEDFA5CNFSM4HZK4KT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZLAOLY#issuecomment-508954415>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AB37QSQNV77SPTFQ6Z7O2YTP6EEDFANCNFSM4HZK4KTQ>.

[EliotJones]

Just doing some tidying up, are you happy to close this issue now?

[Numpsy]

Yes, it looks good now, i'll close the issue.