Giter Site home page Giter Site logo

Comments (4)

uhho avatar uhho commented on September 26, 2024

@FredericMarkert Definitely agreed. Thanks a lot!
I've changed just one thing; when looking for neighbours there is no need to include the core point itself. So I think we can use _regionQuery() function here.

Next time, please feel free to send a pull request!

from density-clustering.

uarga avatar uarga commented on September 26, 2024

I'm glad to be helpful.

About including the core point: I wasn't sure about that, as the original paper does not elaborate on whether it's a closed or open neighborhood...

from density-clustering.

uarga avatar uarga commented on September 26, 2024

Well, I'm confused. The following regards DBSCAN, but should be analogue to OPTICS:

In the DBSCAN wikipedia article, it is stated that core points are included:

regionQuery(P, eps): return all points within P's eps-neighborhood (including P)

In the article talk section, I asked whether this is a mistake:

The authors do not elaborate on whether it's a closed or open neighborhood. The last sentence of the article about neighborhoods [...] would suggest to exclude P unless it is explicitly stated otherwise.

Here's a reply:

In a database context, such as when using an R*-tree as recommended by the authors, the query would include the query point. It is part of the database, too

Can you clarify?

from density-clustering.

uhho avatar uhho commented on September 26, 2024

I've just released new version (1.2.0). From now core points are included in region queries, both in DBSCAN and OPTICS.

from density-clustering.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.