Comments (3)
I understand your point, but there are a couple of reasons why we went with this setup:
- maintain consistency between UI Router framework implementations
- give a flexible way to handle complex DOM structures
There are cases where you don't want the active
class to be attached to the UISref
component because of some tricky DOM structure in your menus:
<UISrefActive class="active">
<li className="some-menu">
<!-- might need some nodes here -->
<UISref to="somewhere">
<a>Some link</a>
</UISref>
</li>
</UISrefActive>
I understand your concern with verbosity but you can always take advantage of React components to take care of that:
const Link = ({ to, activeClassName, children }) =>
<UISrefActive class={activeClassName}>
<UISref to={to}>{children}</UISref>
</UISrefActive>;
// ...
<Link to="somestate" activeClassName="active"><button>Some link</button></Link>
or even:
import React, {createElement} from 'react';
const Link = ({ to, activeClassName, element, children }) =>
<UISrefActive class={activeClassName}>
<UISref to={to}>{createElement(element, {}, children)}</UISref>
</UISrefActive>;
// ...
<Link to="somestate" activeClassName="active" element="button">Some link</Link>
from react.
That makes sense, however I still think there should be less verbose way to do this. What about just adding optional activeClassName
to UISref
and let user decide whether can use shorter syntax or whether UISrefActive
is required? It feels weird having two ways to do the same thing, but I believe out of the box simplicity is worth it.
Components are fun and do solve the problem if you have a lot of UISref
s with active class name, but you either have to create new for every file or have yet another imported file - which introduces verbosity by itself.
from react.
have yet another imported file
Composing the two together like in @elboman's example would actually cut down on imports. Instead of import {UISrefActive, UISref} from '@uirouter/react'
, it would become import Link from './my-components
.
adding optional activeClassName to UIS
This would make the library more complex. Adds more code and logic and also makes implementation more complex. What happens when a user has both UISrefActive and adds the optional activeClassName?
Marking this as closed since it is both old and alternate solutions have been presented.
from react.
Related Issues (20)
- Can ui-router/react support React18 new features? HOT 6
- testing ui router with relative paths
- {location: 'replace'} doesn't work in stateService.go(stateName, params, {location: 'replace'}) HOT 1
- useSref: "target="_blank" ignored when link contains child elements HOT 1
- Is this project still under active development? HOT 3
- Use same UIRouter instance inside different React.render(...) HOT 1
- Typescript demo errors on `1.0.1` HOT 1
- animating-transitions demo errors on `1.0.1` HOT 1
- Router.start() called more than once HOT 1
- 404 on react-dom.js on the tutorial pages HOT 2
- Path duplication after page refresh when using UIRouter pushStateLocationPlugin HOT 4
- Params of type json are not deserialized properly HOT 5
- States not gets enabled if there are nested lazy loaded states HOT 2
- UIView Doesn't Render with Usage of `urlService.rules.when` HOT 4
- Scroll restoration HOT 3
- Cannot use useRouter HOT 4
- Jest/Enzyme Transition Rejection/TypeError HOT 1
- UISref Component ignores target="_blank" on child anchor tag HOT 3
- Mocking UiRouter Classes with Jest HOT 4
- useCurrentStateAndParams don't reacting on initial state HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react.