Giter Site home page Giter Site logo

Comments (3)

ulfryk avatar ulfryk commented on June 12, 2024

Hi great idea!

But I see 2 issues (1st one is production issue, 2nd it's just my own, opinionated 'but'):

  1. Will not work for minified code
  2. I don't like union types ( string | angular.IModule ). I prefer totally strict typing.

from angular-typescript.

thakerng avatar thakerng commented on June 12, 2024

Thank you for your recommendation

  1. It's fine even through minification is a limitation, But that's just an option I got the idea from extracting the dependencies in Angular that has the same limitation as well.
  2. I look that like another overload function I prefer to look a module like a class or an object rather than a string

from angular-typescript.

ulfryk avatar ulfryk commented on June 12, 2024
  1. I'll probably update it with your idea - maybe you can create pull request with "service name omission" only :)
  2. I'm thinking of better way - omit module/module name totally (#3), so you get:
@service('myService')
class MyService { … }


Thx for advices and ideas ;)



from angular-typescript.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.