Giter Site home page Giter Site logo

Microsoft Edge about responsive_checkout HOT 3 CLOSED

InteliClic avatar InteliClic commented on June 23, 2024
Microsoft Edge

from responsive_checkout.

Comments (3)

perrytew avatar perrytew commented on June 23, 2024

Nick,
Still no solution. This issue has made it to our next sprint, so I'll have a solution by 2/5.
Sorry for the delay.

Internal Note: JIRA RESTAPI-5

from responsive_checkout.

InteliClic avatar InteliClic commented on June 23, 2024

Thanks for the update Perry. Definitely looking forward to a solution.

Currently showing edge users a notice letting them know we are incompatible, asking them to use another browser.

from responsive_checkout.

perrytew avatar perrytew commented on June 23, 2024

Nick,
I've walked through this several times. The issue seems to be with the localstorage.

There's something I don't understand.
When the checkout page loads, you're loading the page from localstorage, a variable named ic-cart.

However, on the quick view page, after adding an item with the addItems() javascript method, where are you saving the cart back to localstorage?

The only place where the localstorage 'ic-cart' variable is set is from within the updateLocalCart() function, The only places that method is called is the login() method, within the document ready method, MyAccountWrapper.loggedIn,

I would expect to see a call to updateLocalCart made from within the addItems() methods between lines 910-911. Also, I don't like line line 910:

window.cart.items = updatedCart.items;

The notion of only updating part of a cart is a bad practice. The totals, subtotals, and all that jazz are updated constantly, especially when adding items to the cart. I would rather see:

window.cart = updatedCart;
updateLocalCart();

Thoughts?

from responsive_checkout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.