Vorto should use ConvertSourceToObject instead of ConvertDataToSource

[umco]

Vorto should use ConvertSourceToObject instead of ConvertDataToSource

[mattbrailsford]

I've created what I think is the right fix here, would you be able to test it?

https://github.com/mattbrailsford/Vorto/tree/bug/convert-source-to-object

[jbreuer]

Sorry didn't have time to test it yet, but the code looks similar to a fix I once made for Archetype so I think this should work :-) kgiszewski/Archetype@07750c7

[mattbrailsford]

Fixed in commit ea5789d

[mattbrailsford]

Just thought I'd write a note hear as this fix has been somewhat reversed in the upcoming release as I've now remembered whilst helping someone else fix an issue why ConvertDataToSource is tried first. The reason is that the editor value is saved as JSON rather than as XML like it would be if it was a normal property. The problem is, normally, during the conversion to XML for the XML cache, ConvertDataToSource would be called and this return value is what is stored in the XML, however because our value is stored as JSON, it never has this conversion happen, so we have to have code that runs ConvertDataToSource first, and if the value still isn't correct, then it tries ConvertSourceToObject.

[mattbrailsford]

Just to note, both methods are still tried, so things should still work as before, it's the fact code was changed to try ConvertSourceToObject first that has been reverted so that ConvertDataToSource is tried first.