Comapibility issue with .NET Core 2.0 Preview 2

[ume05rw]

Comapibility issue with .NET Core 2.0 Preview 2

[ume05rw]

Thank you for using this!

I do not know what kind of scene it will happen, so imagine and write.
If you use it occasionally, library can not detect changes in the IP address of the device, use old IP address.

Once connected, Sharpcifs keeps holding the value of the local IP address at the time of connection.
If the address changes, try the SmbFile.Initialize();

Execution order is:
SharpCifs.Config.SetProperty ("jcifs.smb.client.laddr", [ip address]);
SmbFile.Initialize();
var smbFile = new SmbFile ("connection uri string");
var list = smbFile.listFiles();

I hope that Google Translate will show you well!

[glent1]

The problem is caused by the call to Socket.SendToAsync(args) in the Send method of SocketEx. The Completed event in SocketAsyncEventArgs never gets called, because (I am guessing) it is running synchronously as mentioned here ...

https://blogs.msdn.microsoft.com/dotnet/2017/06/07/performance-improvements-in-net-core/

I read the source of socket.cs and whilst I think the boolean that SendToAsync sets might mean it ran synchronously, I'm not sure. If it is, just doing this in SocketEx.Send will fix the issue ...

if (SendToAsync(args))
{
if (!evt.Wait(_soTimeOut))
{
throw new TimeoutException("No data sent.");
}
}

If not, replacing the whole method with this ...

public void Send(byte[] buffer, int offset, int length, EndPoint destination = null)
{
using (var evt = new ManualResetEventSlim(false))
{

            base.BeginSendTo(buffer, offset, length, SocketFlags.None, destination ?? RemoteEndPoint, new AsyncCallback(delegate { evt.Set(); }), this);
            if (!evt.Wait(_soTimeOut))
            {
                throw new TimeoutException("No data sent.");
            }
        }
    }

definitely will.

[MCord]

I am seeing the same behavior. You solution works perfectly. Thanks !

[ume05rw]

Thanks for your feedbacks!

I could not reproduce in my own environment(Win10, .NetCore2.0 SDK),
"SocketAsyncEventArgs.Completed" event always raised on my code.
Please tell me about your environment.

and, fix SocketEx.cs on dev-branch:
https://github.com/ume05rw/SharpCifs.Std/blob/dev/SharpCifs.STD1.3/Util/Sharpen/SocketEx.cs

I am glad if you try this code to see if it works correctly.

[glent1]

Your environment is the same as mine. I am seeing the behaviour via a Windows .Net Core 2.0 Test Project. Interestingly, the problem does not happen in an Android deployment of the code.

Your dev-branch SocketEx fixes the problem.

I'm looking forward to you updating your nuget package so I can dispense with the local copy of the code.

By the way - thanks for this project!

[ume05rw]

I published now, new ver 0.2.10.
https://www.nuget.org/packages/SharpCifs.Std/0.2.10

thank you everyone!

[ume05rw]

Does anyone still have a look at this issue?
I could not reproduce this problem, so it's a bit indigestion...

If problems also occur, I will resume this issue!

[MCord]

I will update the package and let you know.

…

On Wed, Oct 4, 2017 at 4:05 AM ume05rw ***@***.***> wrote: Does anyone still have a look at this issue? I could not reproduce this problem, so it's a bit indigestion... If problems also occur, I will resume this issue! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABebZ7BDxc7DETm2k7jfN8lNX70rP5SZks5souf7gaJpZM4OyXj5> .

[MCord]

Sorry for the late response. I can confirm that the new version works without any issue!

…

On Wed, Oct 4, 2017 at 8:07 AM Mehran Kordi ***@***.***> wrote: I will update the package and let you know. On Wed, Oct 4, 2017 at 4:05 AM ume05rw ***@***.***> wrote: > Does anyone still have a look at this issue? > I could not reproduce this problem, so it's a bit indigestion... > > If problems also occur, I will resume this issue! > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#9 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABebZ7BDxc7DETm2k7jfN8lNX70rP5SZks5souf7gaJpZM4OyXj5> > . >