HandlerElementMap is never cleared

[ggrossetie]

HandlerElementMap is never cleared

[afdia]

Thanks for the suggestion, but I would defer such a fundamental refactoring until we have the demand for that (especially because the multi-platform structure is already quite complex and hard to get into for new developers, so I would avoid further modularization for now)

[afdia]

Hi

If you just want a method to access and clear the map, I would suggest to use Java Reflection:

HandlerElementMap.setHandlerForElement(null, null);
Field field = HandlerElementMap.class.getDeclaredField("gridElementToHandlerMapping");
field.setAccessible(true);
HashMap<GridElement, DiagramHandler> gridElementToHandlerMapping = (HashMap<GridElement, DiagramHandler>) field.get(null);
gridElementToHandlerMapping.clear();

Changing the code at this location which is referenced several 100 times at various locations is quite risky so I would avoid it for the moment.

Btw: Kroki looks like a real nice project :) As Umlet is quite old and was never designed to run 24/7 I hope there is no other bug which cause problems.
Maybe you could also run Umlet batch exports as a subprocess (as described in e.g. https://stackoverflow.com/questions/636367/executing-a-java-application-in-a-separate-process), then it should be guaranteed to cleanup everything (but of course the overhead would be higher I guess) and you would have the guarantee of a stable API

[ggrossetie]

Maybe you could also run Umlet batch exports as a subprocess (as described in e.g. stackoverflow.com/questions/636367/executing-a-java-application-in-a-separate-process), then it should be guaranteed to cleanup everything (but of course the overhead would be higher I guess) and you would have the guarantee of a stable API

Yes, I've successfully created a native image of UMlet from my fork: https://github.com/yuzutech/umlet/tree/mini.
If it's something that might interest you (i.e., a CLI with a native-image produced by GraalVM), I can see how to integrate it upstream.

Cheers!

[ggrossetie]

Alright, should I close this issue?

[afdia]

I will close it thanks!