Giter Site home page Giter Site logo

Comments (2)

AxelTWC avatar AxelTWC commented on June 26, 2024

New PR above

The PR above current does not include test cases yet.
@syedahmed1674 Will Push Test Cases later and will make a comment again

PR Title

Support the implementation of Display Color assignment with Parenthesis.

Example

displayColor = "red" <-- This does not work originally

PR Description

It was originally stated by @syedahmed1674 that by implementing the following into UmpleInternaalParser_CodeLayout + _CodeClass:

theColor = theColor.replace("=", ""); // Remove all '=' characters
theColor = theColor.replace(""", ""); // Remove all '"' characters

It would fix the issue by replacing any parsed values for the Coloring to remove the assignment sign and the quotation sign, It was later found that it does not pass through Grammar Test Cases and raises error 1502.

It was later discovered by @AxelTWC debugging that by removing the code:

      if(!theColor.startsWith("\"")) theColor= "\""+theColor;
      if(!theColor.endsWith("\"")) theColor= theColor+"\"";

It solves the issue where there will not be an extra " whenever having a quotation valued assignment
(Originally Debugging Gives " "red" by doing displayColor = "red" | It should fix the issue now)
A full build was ran and passes all previous cases in prior to making sure this works perfectly.

@syedahmed1674 Will Push Test Cases Specifically for this PR #2060 /Issue #2056

from umple.

TimLethbridge avatar TimLethbridge commented on June 26, 2024

Fixed by #2060

from umple.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.