FastRouter hangs on request with non-subscribed domain

[unbit]

FastRouter hangs on request with non-subscribed domain

[unbit]

can you try if changing line 367 to 'return 0' fixes the issue ?

like this
// check instance
if (cs->instance_address_len == 0) {
// if fallback nodes are configured, trigger them
if (ucr->fallback) {
cs->instance_failed = 1;
}
return 0;
}

[prymitive]

Yes it does, since You didn't mentioned what file should I modify I did a little grep to make sure and I've patched fastrouter.c and http.c, corerouter still runs old code

diff --git a/plugins/fastrouter/fastrouter.c b/plugins/fastrouter/fastrouter.c
index c462001..9e4f1e8 100644
--- a/plugins/fastrouter/fastrouter.c
+++ b/plugins/fastrouter/fastrouter.c
@@ -288,7 +288,7 @@ ssize_t fr_recv_uwsgi_vars(struct corerouter_session * cs) {
                        if (ucr->fallback) {
                                cs->instance_failed = 1;
                        }
-                       return -1;
+                       return 0;
                }

                // stop receiving from the client
diff --git a/plugins/http/http.c b/plugins/http/http.c
index 7869467..78c80ff 100644
--- a/plugins/http/http.c
+++ b/plugins/http/http.c
@@ -1000,7 +1000,7 @@ ssize_t hs_http_manage(struct corerouter_session * cs, ssize_t len) {
                                if (ucr->fallback) {
                                        cs->instance_failed = 1;
                                }
-                               return -1;
+                               return 0;
                        }

                        // stop receiving from the client

[unbit]

yes, it's ok, i will make a check on all of the areas where we need to suddenly close the connection.

[unbit]

i have preferred a more drastical approach, resetting errno before each hook invocation. Can you check if all is working as expected ?

[prymitive]

Yes it does, thanks