Comments (4)
Hello @UncleRus
Thanks for the advice and guidance.
The first time, I m trying to contribute to the open-source repo, I m not well known about coding standards and other things.
I will update lib as per the coding standard and your instructions.
Thanks!
from esp-idf-lib.
I tried to port the driver code of Dallas DS243. Here is the link,
I do not have the device so not tested the code on the device if anyone has can test and update me.
If it works I will try to create the merge request.
It's building successfully on esp idf v4.4.1.
Thanks.
from esp-idf-lib.
Hi @Raghav3107 !
First of all, thank you.
- The first and most important note: drivers must be stateless! If you need to save some state between calls, the device descriptor structure is used. Your library can only be used with single device, because of the saving device GPIO and mode to internal
_pin
and_mode
variables. The same goes for theds2438_update()
function: it should just read and return the voltage and temperature values without saving them. To avoid this, declare device descriptor struct and pass it by pointer to all functions. - Please avoid
int
parameters when they can be replaced with enums. - Please add C++ guards in header.
- Move internal definitions such as register numbers from the header to the source. They are only used internally and pollutes the global namespace in header.
- Clean includes in header. Why is there
stdio.h
andstdlib.h
? - Avoid using of
func(void)
instead offunc()
. - Do not use tabs. Spaces only.
from esp-idf-lib.
Hello @UncleRus.
I updated the repository as per your instruction.
Can you please check it once again?
Thanks!
from esp-idf-lib.
Related Issues (20)
- SR04 ultrasonic sonar issue HOT 3
- Porting VL53L1X driver HOT 1
- ACK issue in wake up command in SCD4x component HOT 1
- cmake fails HOT 3
- Encoder: Example panics HOT 2
- HX711: Calibration factor (float required) HOT 1
- Redundant i_expected_max parameter when calibrating ina219
- MCP23017 Example throws an error when using interrupts HOT 2
- Write to config register triggers start conversion on ADS1115
- Support for BQ27441-G1
- Having issues using the TCA9548 code for my VEML7700
- SHT4x often gives "i2cdev: Could not read from device [0x44 at 0]" error on measurement HOT 2
- Strange behavior with BME280 + MAX17048 HOT 4
- Problem with nested structs in BME680-Driver / IĀ²C-init
- error in bme680_convert_temperature() when temperature is below 0 HOT 2
- Unable to read from HX711 with esp-idf-lib HOT 2
- Watchdog timer reset after BME280 initialization on ESP32C3 HOT 1
- INA219 - Wrong current reading
- Integration Proposal for Software Testing using Wokwi Simulator CI in esp-idf-lib
- [sht3x]: i2cdev: Could not write to device [0x44 at 0] HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from esp-idf-lib.