tsc reports incorrect / missing types

[unifiedjs]

tsc reports incorrect / missing types

[NullVoxPopuli]

cross reported here: vfile/vfile#47

[ChristianMurphy]

vfile 4 and vfile-message 2 include typings built in.
vfile 3 and below as well as vfile-message 1 require typings to be installed from definitely typed.

either upgrade dependencies through the tree to get the versions that include typings or install @types/vfile-message

[ChristianMurphy]

FWIW, I use TS with Stylelint as well, and do not have have this issue.
There may be something specific to your build (webpack) or typescript configuration that is causing the conflict.
If you'd like help with that feel free to open a question at https://spectrum.chat/unified/type-definitions with more context on your build configuration.

[NullVoxPopuli]

I have:

vfile 3.0.1, as a dep of unified.
unified 7.1.0 as a dep of remark.
remark 10.0.1 (latest is 11.0.2) as a dep of postcss-markdown # <-- this could be the issue here
postcss-markdown 0.36.0 (latest) as a dep of stylelint <- needs to upgrade remark
  - has remark specified as: `"remark": "^10.0.1",`
[email protected] (latest) is my direct dependency.

I'll bring my issue to postcss-markdown

[NullVoxPopuli]

This looks promising: https://github.com/gucong3000/postcss-markdown/issues

🤦‍♂️

[NullVoxPopuli]

FWIW, I use TS with Stylelint as well, and do not have have this issue.

you'd have to be using the master branch of postcss-markdown
or maybe have remark 11 installed yourself?

[ChristianMurphy]

No customization

• stylelint 13.0.0
• react-scripts (Create react app) 3.3.0
• typescript 3.7.5

with tsconfig

{
  "compilerOptions": {
    "baseUrl": "src",
    "target": "es5",
    "lib": ["dom", "dom.iterable", "esnext"],
    "allowJs": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "noEmit": true,
    "jsx": "preserve"
  },
  "include": ["src"]
}

remark, unified, and vfile all are included with their standard transitive version provided by stylelint.

[drwpow]

I’m seeing the same as @NullVoxPopuli. @ChristianMurphy just out of curiosity, if you delete node_modules and package-lock.json/yarn.lock, and npm install, does your build still work? I’m wondering if in your project you are locked to an older version resolution.

[ChristianMurphy]

@DangoDev the package-lock.json and node_modules have been updated regularly, I did again today for good measure, the build still works.
I suspect it has to do with CRA setting "skipLibCheck": true

[drwpow]

I suspect it has to do with CRA setting "skipLibCheck": true

Ah you may be onto something there

[NullVoxPopuli]

For those using the new(ish) tsc --build, skipLibCheck isn't an option (or at the very least isn't available via --skipLibCheck)

[ChristianMurphy]

@NullVoxPopuli this appears to be a tangentially related or unrelated to the original question?
To start a new discussion consider opening a thread at https://github.com/unifiedjs/unified/discussions

In addition, the TypeScript docs, make no mention of build restricting skipLibCheck it may be unrelated to the mode.

[NullVoxPopuli]

👍

I just tested with the tsconfig.json flag, and it works as described by others.

(Wouldn't recommend it tho)

[ChristianMurphy]

@NullVoxPopuli nobody here said it was recommended. 🤨
It's a work around for packages which haven't updated to the latest version which includes typings.

---

If you disagree with CRA's choice to use the flag, that would be something to take up with CRA directly https://github.com/facebook/create-react-app/issues