How do you build it?

[unitsofmeasurement]

How do you build it?

[ptahchiev]

I was able to build it by adding some extra requires tech.uom.lib.common; in the module-info

[ptahchiev]

Does this need to be fixed? Do you want me to submit a PR?

[keilw]

Hi, this is a bug in Java 11 as well despite its LTS label it isn't as stable as sugested, especially with Jigsaw and Multi-Release-JARs.
The bug is summarized and pointed to here: https://stackoverflow.com/questions/53581799/jdeps-command-use-with-multi-release-option-failed

I cannot say for sure, what is the other issue, because it seems to fail even in Java 14 while Multi-Release-JAR problems we saw in the past no longer showed in
Please use Java 9 for now, it works perfectly fine with that.

[keilw]

If you found additional imports in the module-info that work above Java 11, please do, the issue you saw first ist a known problem in the JDK.

[ptahchiev]

Thank you for your reply. I have created a PR to fix the build but I now have a new question. I add the uom-retail-quantity dependency to my pom.xml and I expect to be able to use the new units box, each and crate automatically. However, when I try to parse from string:

ServiceProvider.current().getFormatService().getUnitFormat().parse("box");

I get a MeasurementParseException because the unit is not found. I see none of the modules in the uom-domain project declare a javax.measure.spi.ServiceProvider and I was wondering if I have to declare one in my project. Or is it a missing feature? I mean I would expect each of the modules in this project to declare their own ServiceProvider to automatically register the units that it provides.

[ptahchiev]

Oops - closed by mistake

[keilw]

But why reopen it, wasn't it fixed by your PR #18?

[sroze]

@keilw any chance you could do a release with that fix? 🙏 Thank you!

[keilw]

We are quite flexible here so I guess together with #16 this justifies a 2.1 release any time soon.

[keilw]

There is however a possible alignment with issues like unitsofmeasurement/uom-systems#177 but it could be done in a 2.1.1 release. So far this library seems independent of uom-systems, it may change in the future.

[ptahchiev]

I want to test it before I close the issue. However I don't know how to use the new units. From above:

However, when I try to parse from string:

ServiceProvider.current().getFormatService().getUnitFormat().parse("box");

I get a MeasurementParseException because the unit is not found. I see none of the modules in the uom-domain project declare a javax.measure.spi.ServiceProvider and I was wondering if I have to declare one in my project. Or is it a missing feature? I mean I would expect each of the modules in this project to declare their own ServiceProvider to automatically register the units that it provides.

[keilw]

As of now there is no SystemOfUnits implementation that would even know a unit BOX.

[ptahchiev]

But what would be the right approach - provide one with the module, or let the customer create his own. If you opt for the first one I can create a PR

[keilw]

Maybe similar to https://github.com/unitsofmeasurement/uom-domain/tree/master/health/health/src/main/java/tech/uom/domain/health/unit in "health" this might help, but note even in "health" there is no full integration with the SPI yet, but unless you go all the way of adding a custom formatter, check out https://github.com/unitsofmeasurement/uom-systems/blob/master/unicode/src/main/java/systems/uom/unicode/CLDR.java and see how SimpleUnitFormat is configured there, that might be sufficient, but keep in mind, it only works for SimpleUnitFormat.

[keilw]

Needs #14

I can fix it for Health, if you would like to create a PR for the "retail" module, there should be no conflicts.
I'll work on #2 and #16 but it is not necessary to recognize those new units to integrate the system with the SPI, that is the cherry on the cake if you want.

[keilw]

Imaging has a dependency already, so we should not release a 2.1 of this module before systems-uom 2.1 was released first.