Giter Site home page Giter Site logo

Comments (4)

mchamler avatar mchamler commented on July 20, 2024 2

If it's not supported, it should throw an exception. It was supported before, so this is a silent breaking change. The current behavior isn't even reasonable, since the call succeeds, but the InjectionFactory is simply dropped from the registration.

from abstractions.

ENikS avatar ENikS commented on July 20, 2024 1

It was discussed here

from abstractions.

mchamler avatar mchamler commented on July 20, 2024

The workaround for this problem is to split up the interface and type registrations. So, the above example would become:
container.RegisterType(new InjectionFactory(cont => FooFactory.Create()));
container.RegisterType<IFoo, Foo>();

I think this is a pretty dangerous bug. If Foo had a public constructor this would have been a silent bug as Foo might be resolved with the wrong state. I've actually found other places in my app where that's exactly what is happening.

from abstractions.

ENikS avatar ENikS commented on July 20, 2024

https://github.com/unitycontainer/unity/releases/tag/5.2.1.311

from abstractions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.