Giter Site home page Giter Site logo

Comments (16)

dyoxyne avatar dyoxyne commented on May 5, 2024 3

Another solution could be Cinemachine Collider extension.
It will however affects the camera behavior (but it is pretty common in 3rd person platformer games).

from open-project-1.

Quickz avatar Quickz commented on May 5, 2024 2

Hi, I think it's a valid bug even though I was hoping to fix it later once we know better how the environment looks like. I think there's no way to fix it, but rather you change the behaviour of the camera.

So for now I think we should leave it open and come back to this later.
I also changed the title of the issue, the previous one (Bug In The Cine-machine Controller) wasn't descriptive of what the bug actually is.

Out of curiosity, what would be your solution?

I can throw in a couple of random ideas in case where moving the camera isn't an option:

Options 1:

Make any object that obscures the view of the player character slightly transparent.

Options 2:

Have the game render a silhouette of the player character through the objects that obscure him.

For a reference here's a screenshot of a game called Overwatch where a character is using an ability which allows her to see enemies (The red silhouettes) through walls.
reference

from open-project-1.

MileyHollenberg avatar MileyHollenberg commented on May 5, 2024 2

Another solution could be Cinemachine Collider extension.
It will however affects the camera behavior (but it is pretty common in 3rd person platformer games).

This would be my way of fixing this issue as well

from open-project-1.

megatank58 avatar megatank58 commented on May 5, 2024 2

@SundarakrishnanN Publish your current files to your fork using GitHub desktop then to go your repository you should see something like this:
image
Click Pull Request
image
And then follow the steps

from open-project-1.

SundarakrishnanN avatar SundarakrishnanN commented on May 5, 2024 1

@SundarakrishnanN Publish your current files to your fork using GitHub desktop then to go your repository you should see something like this:
image
Click Pull Request
image
And then follow the steps

Hey @megatank58
Thanks a lot for your help..It worked!

from open-project-1.

ciro-unity avatar ciro-unity commented on May 5, 2024

Hi, I think it's a valid bug even though I was hoping to fix it later once we know better how the environment looks like. I think there's no way to fix it, but rather you change the behaviour of the camera.

So for now I think we should leave it open and come back to this later.
I also changed the title of the issue, the previous one (Bug In The Cine-machine Controller) wasn't descriptive of what the bug actually is.

Out of curiosity, what would be your solution?

from open-project-1.

ElgenTidwell avatar ElgenTidwell commented on May 5, 2024

I would like to help fix this issue using a dynamic system that works with any type of environment.

from open-project-1.

SundarakrishnanN avatar SundarakrishnanN commented on May 5, 2024

Hi, I think it's a valid bug even though I was hoping to fix it later once we know better how the environment looks like. I think there's no way to fix it, but rather you change the behaviour of the camera.

So for now I think we should leave it open and come back to this later.
I also changed the title of the issue, the previous one (Bug In The Cine-machine Controller) wasn't descriptive of what the bug actually is.

Out of curiosity, what would be your solution?

Hi,
My solution would be to use the extension(Cine-machine Collider) and I would tweak a few values in the same(to make it better and smooth).
I have tried the same in the clone of the project and it is working fine.....I would like to do it sir....A lot of them are also volunteering to solve the bug, but I would like to solve this bug... A lot of requirements in the game, doesn't seem that suited to me...Hence, I searched if there was any bug which I could solve and I found this.. I would be glad to show a fix to this bug(which is perfectly of my level, compared to other required tasks right now).Also I will look into other possible solutions until I receive
a reply.(but the above mentioned method would be my preferred solution) Hoping for a reply on whom the project is assigned...
Thank you,
Sundarakrishnan N

from open-project-1.

SundarakrishnanN avatar SundarakrishnanN commented on May 5, 2024

I would like to help fix this issue using a dynamic system that works with any type of environment.

No , please dont work on it , I already found a fix...

from open-project-1.

Sposito avatar Sposito commented on May 5, 2024

No , please dont work on it , I already found a fix...
Hey @SundarakrishnanN how familiar are you with working collaboratively on projects like this? You can always open a PR with your changes so people can comment on your solution even if it isn't meant to get in right away. Feel free to ping me if you wanna talk about it.

from open-project-1.

SundarakrishnanN avatar SundarakrishnanN commented on May 5, 2024

No , please dont work on it , I already found a fix...
Hey @SundarakrishnanN how familiar are you with working collaboratively on projects like this? You can always open a PR with your changes so people can comment on your solution even if it isn't meant to get in right away. Feel free to ping me if you wanna talk about it.

Hi, @Sposito I am not at all familiar with working on GitHub...So could you please help me out with how I can implement the changes on the original version...I downloaded a clone of the project and I fixed it...There were no changes to the scripts, there were changes to the values in the Cine-machine.. Please help me out in proceeding further..
Thank you

from open-project-1.

megatank58 avatar megatank58 commented on May 5, 2024

Is anyone working on this yet? I wanna work on this

from open-project-1.

SundarakrishnanN avatar SundarakrishnanN commented on May 5, 2024

Is anyone working on this yet? I wanna work on this

Hey @megatank58 , I have fixed this issue in a clone of the project but since I am not yet assigned by unity,I am not sure how I can implement the changes in the official project(I am new to GitHub, I would be glad if someone helped me by explaining about GitHub and how I can implement the changes done in the clone of the project in the official version)..
Thank you

from open-project-1.

megatank58 avatar megatank58 commented on May 5, 2024

Is anyone working on this yet? I wanna work on this

Hey @megatank58 , I have fixed this issue in a clone of the project but since I am not yet assigned by unity,I am not sure how I can implement the changes in the official project(I am new to GitHub, I would be glad if someone helped me by explaining about GitHub and how I can implement the changes done in the clone of the project in the official version)..
Thank you

Just open a PR on the Pull Request page (near Issues) on GitHub page of this repository and click New PR then upload all the files,i too am working on this right now

from open-project-1.

SundarakrishnanN avatar SundarakrishnanN commented on May 5, 2024

Hey, @ciro-unity
I am not able to create a pull request here , so I committed the fix in the fork of the project
Link to the Fix : SundarakrishnanN@fe02b89
Is this enough? Is the solution good enough? How else should I proceed to make the changes in the original version?
Thank you,

from open-project-1.

ciro-unity avatar ciro-unity commented on May 5, 2024

We can finally close this issue! Thanks to @shuttle127 in PR #220, we have a shading pass which draws characters when occluded by the scenery 🎉
Thanks for the discussion everyone!

from open-project-1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.