Comments (2)
Final decision will be made by the author, but IMHO, optional catch binding is old enough to be available in most environments.
While adding argument is just a one-line fix, the action means that maintainers will continue to support legacy environments, and we have to make a decision to drop legacy environments at some point in future after all.
That's because otherwise we could not keep packages valuable for users for foture (e.g. transpiling TS to old version JS would weigh the package size due to patch code / Vue dropped IE support to use Proxy). By the way, at the moment, hookable is CI-tested with Node.js 16 , whose support was already ended last year.
Although I do know supporting legacy environments is important in some context (I used to do the job in the past!), I am also for that OSS should be open for future enhancement, as one of OSS maintainers.
In this time, while waiting for the authors decision, I provide some information by which you could overcome the situation without upstream changes.
Transpiling dependency
Although I don't know details of your development tooling, you might be able to let bundler transpile your dependency on build by setting some options.
Patching package
Another approach is to patch dependency.
Whichever the author fixes the code or you modify your code, I hope my comment help you resolve the issue somewhat 🙌
from hookable.
Nothing to add on top of what @NozomuIkuta said 💯 Still if you are in a situation that locked in (for example a framework that uses older version of Webpack without syntax support, please mention so we can follow this up here or there.)
from hookable.
Related Issues (19)
- Cannot find module 'hable' HOT 1
- Action Required: Fix Renovate Configuration
- Fully typed nested/namespaced hooks (for `addHooks`) HOT 2
- TypeScript Examples HOT 7
- `callHookSync`
- Allow differed hook calling
- hook events
- Dependency Dashboard
- closed
- Debugger
- Is there a way to clear all hooks? HOT 3
- Debugger handling parallel hook calls with same name
- Type 'HooksT' does not satisfy the constraint 'Record<string, any>' HOT 4
- Synchronous Hooks HOT 4
- set caller
- Allow to return value from callback function HOT 1
- Typescript: Template class extend Hookable type issue
- Allow register hooks with `enforce: before|after`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hookable.