Comments (4)
Base on "USING an alternate 'class'" where we'll want layout settings like css classes and background image, i think we probably want to create a "DCF Layouts" module
from project-herbie.
Will probably want to split the DCF layouts module out into its own project someday but for now i've just included it in the main project
from project-herbie.
- Layouts can be used without Layout Builder. Layout Discover is needed to register layouts, however.
dcf_layouts.info.yml
dependencies:
- - layout_builder
+ - layout_discovery
-
If DCF Layouts is going to reside within this project (for now), it should be moved to /web/modules/custom/dcf_layouts
-
Code Review
$ phpcs --standard=Drupal,DrupalPractice dcf_layouts/
FILE: ...ge2/Sites/project-herbie-eric/web/modules/dcf_layouts/dcf_layouts.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
11 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
--------------------------------------------------------------------------------
FILE: ...erbie-eric/web/modules/dcf_layouts/src/Plugin/Layout/ThreeColumnLayout.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
27 | ERROR | [x] Concat operator must be surrounded by a single space
27 | ERROR | [x] Concat operator must be surrounded by a single space
31 | ERROR | [x] Concat operator must be surrounded by a single space
31 | ERROR | [x] Concat operator must be surrounded by a single space
35 | ERROR | [x] Concat operator must be surrounded by a single space
35 | ERROR | [x] Concat operator must be surrounded by a single space
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...-herbie-eric/web/modules/dcf_layouts/src/Plugin/Layout/TwoColumnLayout.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
27 | ERROR | [x] Concat operator must be surrounded by a single space
27 | ERROR | [x] Concat operator must be surrounded by a single space
31 | ERROR | [x] Concat operator must be surrounded by a single space
31 | ERROR | [x] Concat operator must be surrounded by a single space
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 98ms; Memory: 8MB
Issue 1 in dcf_layouts.info.yml can be ignored. This module isn't being hosted on Drupal.org.
-
Layout implementation issues - There are issues with some of the layouts. I'll document those in a separate post.
-
We should have a conversation about the Builder Page content type and how it fits within a larger content strategy.
from project-herbie.
DCF One Column
- 100% OK
DCF Two Column
- 50%/50% OK
- 33%/67% OK
- 67%/33% OK
- 25%/75% OK
- 75%/25% OK
DCF Three Column
- 25%/50%/25% - Second region always 12/12 span
- 33%/34%/33% - Second region always 12/12 span
- 25%/25%/50% - Second region always 12/12 span
- 50%/25%/25% - Second region always 12/12 span
DCF Four Column
- 25%/25%/25%/25% - No DCF classes are printing
- No layout configuration options available
from project-herbie.
Related Issues (20)
- WYSIWYG editor displays lower-alpha sub-list in ol, but actual page displays numbers at both levels
- Review responsive image breakpoints on Windows HOT 1
- Original files that contain encoded characters don't load on default site paths HOT 1
- Embed Yuja videos
- Archive page followup
- Add college "College of Public Affairs and Community Service" to Major content type
- Menu blocks included in Temporary Transition pages have extra spacing between menu items
- Adjust permissions for HTML Code Component HOT 1
- Can't edit People Block with view mode "Teaser Centered" in Layout Builder HOT 3
- Can't add reference link of a file in a Person content type
- Creating a Tandem and adding a Button Link to it during the initial creation step causes an error,
- Add padding for default link list in body of book page.
- Enable Right align text option
- Create Tags field for a node
- Node Include Component Error
- “The element ‘h3’ must not appear as a descendant of the ‘address’ element.” Error
- Bug when editing existing Tandem component
- Group content not viewable by users without site access
- Group: Site Title cached
- Make accordion component title optional
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from project-herbie.