Set up Layout Builder and create DCF/UNL Layouts

[unlcms]

Set up Layout Builder and create DCF/UNL Layouts

[ericras]

Base on "USING an alternate 'class'" where we'll want layout settings like css classes and background image, i think we probably want to create a "DCF Layouts" module

[ericras]

Will probably want to split the DCF layouts module out into its own project someday but for now i've just included it in the main project

[macburgee1]

1. Layouts can be used without Layout Builder. Layout Discover is needed to register layouts, however.

dcf_layouts.info.yml

  dependencies:
-   - layout_builder
+   - layout_discovery

2. If DCF Layouts is going to reside within this project (for now), it should be moved to /web/modules/custom/dcf_layouts

3. Code Review

$ phpcs --standard=Drupal,DrupalPractice dcf_layouts/

FILE: ...ge2/Sites/project-herbie-eric/web/modules/dcf_layouts/dcf_layouts.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
  1 | WARNING | Remove "version" from the info file, it will be added by
    |         | drupal.org packaging automatically
 11 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
--------------------------------------------------------------------------------


FILE: ...erbie-eric/web/modules/dcf_layouts/src/Plugin/Layout/ThreeColumnLayout.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 27 | ERROR | [x] Concat operator must be surrounded by a single space
 27 | ERROR | [x] Concat operator must be surrounded by a single space
 31 | ERROR | [x] Concat operator must be surrounded by a single space
 31 | ERROR | [x] Concat operator must be surrounded by a single space
 35 | ERROR | [x] Concat operator must be surrounded by a single space
 35 | ERROR | [x] Concat operator must be surrounded by a single space
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...-herbie-eric/web/modules/dcf_layouts/src/Plugin/Layout/TwoColumnLayout.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 27 | ERROR | [x] Concat operator must be surrounded by a single space
 27 | ERROR | [x] Concat operator must be surrounded by a single space
 31 | ERROR | [x] Concat operator must be surrounded by a single space
 31 | ERROR | [x] Concat operator must be surrounded by a single space
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 98ms; Memory: 8MB

Issue 1 in dcf_layouts.info.yml can be ignored. This module isn't being hosted on Drupal.org.

4. Layout implementation issues - There are issues with some of the layouts. I'll document those in a separate post.

5. We should have a conversation about the Builder Page content type and how it fits within a larger content strategy.

[macburgee1]

DCF One Column

• 100% OK

DCF Two Column

• 50%/50% OK
• 33%/67% OK
• 67%/33% OK
• 25%/75% OK
• 75%/25% OK

DCF Three Column

• 25%/50%/25% - Second region always 12/12 span
• 33%/34%/33% - Second region always 12/12 span
• 25%/25%/50% - Second region always 12/12 span
• 50%/25%/25% - Second region always 12/12 span

DCF Four Column

• 25%/25%/25%/25% - No DCF classes are printing
• No layout configuration options available