Giter Site home page Giter Site logo

Deadlock in metrics about unleash-client-go HOT 2 CLOSED

unleash avatar unleash commented on June 20, 2024
Deadlock in metrics

from unleash-client-go.

Comments (2)

jrbarron avatar jrbarron commented on June 20, 2024

@yukw777 Thanks for the report. This deadlock issue is known and documented here (last sentence under "Basics"):

https://godoc.org/github.com/Unleash/unleash-client-go#hdr-Basics

It was a side effect of the API design where I wanted to force people to use a listener so as not to ignore errors which as you know is bad practice in Go. In retrospect, this may have been a mistake so I have contemplated changing it, perhaps in the v3 branch.

The additional bugs you mention there certainly sound valid so I'll try to take a look at those when I get some time. I will happily accept a PR for these too if you have something ready. I've also starting writing some unit tests for the metrics struct now so hopefully that will catch some of these issues.

Thanks for the great report!

from unleash-client-go.

jrbarron avatar jrbarron commented on June 20, 2024

The bugs relating to disabling metrics and also the deadlocks (except for the nil Listener which is documented) should now be fixed so I'm closing this.

from unleash-client-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.