Comments (2)
@yukw777 Thanks for the report. This deadlock issue is known and documented here (last sentence under "Basics"):
https://godoc.org/github.com/Unleash/unleash-client-go#hdr-Basics
It was a side effect of the API design where I wanted to force people to use a listener so as not to ignore errors which as you know is bad practice in Go. In retrospect, this may have been a mistake so I have contemplated changing it, perhaps in the v3
branch.
The additional bugs you mention there certainly sound valid so I'll try to take a look at those when I get some time. I will happily accept a PR for these too if you have something ready. I've also starting writing some unit tests for the metrics struct now so hopefully that will catch some of these issues.
Thanks for the great report!
from unleash-client-go.
The bugs relating to disabling metrics and also the deadlocks (except for the nil Listener which is documented) should now be fixed so I'm closing this.
from unleash-client-go.
Related Issues (20)
- Is there a way to get all the feature flags for a project, not just one at a time? HOT 2
- Proposal: be more strict about WithListener HOT 4
- Implement Global Segments
- (Feature Request) Enable passing api.Feature instead of a string to an alternative of IsEnabled HOT 12
- Update link to GoDoc HOT 2
- openfeature HOT 2
- infinitely blocked in metrics.count with gitlab HOT 3
- Back-off strategy for calling Unleash HOT 2
- Missing v3.9.0 Release Notes HOT 1
- Return variant and feature enabled from a single method HOT 5
- WithVariantFallback and WithVariantFallbackFunc are called when feature isn't found HOT 3
- Avoid fetching feature again in GetVariant HOT 4
- Add Type to api.Feature HOT 1
- Expose admin API HOT 1
- fix: GetVariant does not accept custom context HOT 1
- Publicly expose the default Strategies for faster and more advanced Strategies. HOT 2
- Unleash context in readme direct to 404 HOT 1
- Why is not options passed when calling GetVariant? HOT 1
- Missing testdata results in failed build HOT 3
- Not able to set Environment in Client HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unleash-client-go.