Unleash client go efficiency

[unleash]

Unleash client go efficiency

[avirogalsky]

I have prepared a branch for it, I just cannot push it to here...
I can open PR on it and we'll discuss above that
So if it will be ok for you guys I will add tests + documentation, and merge

[jrbarron]

Hi @avirogalsky, thanks for the report. The Go version of the client was based on the Node version of the client which behaves the same way:

https://github.com/Unleash/unleash-client-node/blob/master/src/client.ts#L84-L100

I agree with you that it is more efficient to set the strategies after the list of feature toggles is fetched, but this obviously increases the complexity as well. If you or someone else wants to implement a PR for this, we can discuss the implementation and see if it is worth it.

[ivarconr]

The JavaClient actually initializes a "map" for direct access to each strategy.

Also: would be good to actual measure this, as the number of strategies are expected to be low.

[avirogalsky]

I think i need access right to upload a branch... it won't let me now
@ivarconr can you allow me to push branches?

[avirogalsky]

@ivarconr @jrbarron see the PR:
#73
we can discuss here or on slack about that....
all changes are not breaking current implementation, only optionally extending

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.