Giter Site home page Giter Site logo

[React-Native] triggers uuid crash when feature with impression data enabled is used with `isEnabled` about unleash-proxy-client-js HOT 4 CLOSED

unleash avatar unleash commented on June 1, 2024
[React-Native] triggers uuid crash when feature with impression data enabled is used with `isEnabled`

from unleash-proxy-client-js.

Comments (4)

andreas-unleash avatar andreas-unleash commented on June 1, 2024 1

Hey, thank you for bringing this to our attention. I will raise the issue with the team.

from unleash-proxy-client-js.

Kei-Neurio avatar Kei-Neurio commented on June 1, 2024 1

Thank you for the quick response and diagnosis @nunogois! I'll check the impression data toggle and post the result here. Just checked proxy-client-react-native and it's an exciting addition to the project. Looking forward to the update!

[update] Yes you are right, it was caused because we had the impression toggle onπŸ‘ I'll leave this issue until some fix goes in place but feel free to close it if you wanted!

from unleash-proxy-client-js.

nunogois avatar nunogois commented on June 1, 2024 1

Hey @Kei-Neurio - Thanks for confirming this!
Our decision for now was to add this React Native/Expo SDK PoC to our Community SDK list here: https://docs.getunleash.io/sdks#community-sdks
If we see it gains traction, we'll probably give more attention to it and promote it to an official SDK. In the meantime, for anyone not using it, there's still the workaround mentioned above.

We'll close this issue for now, but please feel free to reach out to us at anytime πŸ™‚

from unleash-proxy-client-js.

nunogois avatar nunogois commented on June 1, 2024

Hi @Kei-Neurio thanks for opening this issue and providing detailed information.

From our tests reproducing the bug it seems like this may not be name-related, but instead impression-data-related. We had no issues with password-named feature toggles, but we did have this issue with features that had impression data enabled.

Can you please confirm this? This can be easily changed in Unleash by going to the specific Feature Toggle > Settings > Feature information (edit) > Enable impression data toggle.

Easiest way to fix this for end-users would be to install and add import 'react-native-get-random-values' at the top of their React Native / Expo app, like mentioned here: https://www.npmjs.com/package/uuid#react-native--expo


My suggestion, however, would be to have a specific proxy-client-react-native package, extremely similar to proxy-client-react but with any specific React Native / Expo caveats built-in, providing more of a plug and play experience for end-users.

Here's a quick PoC: proxy-client-react-native

I'll check with the rest of the team on the best way forward regarding this and will let you know πŸ™‚

from unleash-proxy-client-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.