Comments (2)
I agree with you, that it would be more user friendly to reduce it to one argument. But at the moment, I only see one simple solution to this problem.
You could just write an if-else clause in the SCMLSystem init-method, which checks the type of the converter-argument. But this would introduce a dependency between the SCMLSystem and a special converter class that I would avoid, because it would complicate the use of a different implementation that merges two converters.
Furthermore we would end up writing spaghetti-code, if we introduce such dependencies everywhere.
If such requirements of using multiple different converters will appear moreoften in the future, a redesign of the SCMLSystem to be able to handle multipleConverters inherently might be useful, because it was designed for the DC and Synchronous Motors. This solution would require much more effort and should consider a bunch of future requirements.
So finally, I would appreciate an elegant solution that handles this issue, but I would avoid additional dependencies between classes.
from gym-electric-motor.
Suitable follow-up after #48 is implemented.
from gym-electric-motor.
Related Issues (20)
- Can you email me, please ? HOT 1
- Log Variables on each Time Step in PMSM Example Notebook[feature request] HOT 10
- incompatibility with gym >0.24.0 HOT 9
- Improve ReferenceGenerator chapter in Gem_Cookbook
- Flat velocity plot for scim_ideal_grid_simulation.py HOT 2
- Limit values for PMSM motor appear to be a peak to peak value vs an amplitude value HOT 2
- Do GEM currently support 3-phase brushless motor control? HOT 3
- Typo in the calculation of the decoupling HOT 1
- Feature Request: migrate from gym to gymnasium HOT 5
- Documentation is showing only current API (no past releases APIs)
- Phase voltage accuracy for PMSM motors HOT 5
- ConstReferenceGenerator enters the reference_name not as string into the env
- gem modularization
- modularization
- CosSinProcessor calculates Cosinus and Sinus based on normalized Epsilon
- DqToAbcActionProcessor calculates advanced angle wrongly
- Extend the GEM cookbook to explain voltage supply usage
- change the nominalization of the voltage
- Change the mapping of discrete switching states in FiniteB6BridgeConverter
- Hi, We are using the GEM library for testing the functionality of PMSM as a part of our undergraduate project. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gym-electric-motor.