Giter Site home page Giter Site logo

Comments (9)

web-padawan avatar web-padawan commented on May 29, 2024

The readme of the starter contains bower install:
https://github.com/vaadin/base-starter-react/blob/v11/README.md#running-the-application

from base-starter-react.

amahdy avatar amahdy commented on May 29, 2024

master should not be the download option for the start pages (for now), the zip file should be generated from https://github.com/vaadin/base-starter-react/archive/p3-preview.zip

It has been agreed long time that front-end starters should use P3, even though Vaadin platform does not support it yet. If for some reason someone really wants instructions for running React app with P2, instructions are available but not highlighted in the download button.

Please follow up the issue #3572 in webpage project internally.

from base-starter-react.

web-padawan avatar web-padawan commented on May 29, 2024

the zip file should be generated from https://github.com/vaadin/base-starter-react/archive/p3-preview.zip

It it generated from V10 and V11 branches, respectively. Please see #12 and #13 for description why we cannot simply use P3 versions for now.

My opinion is that we should have a working Webpack config to be used with all the starters. Not sure how much are we ready to invest into this, for now I'm recommending users to use my own starter:
https://github.com/web-padawan/polymer3-webpack-starter

I've put significantly more effort into it, both CF and personal evening coding, and I believe that is how the proper starter should look like.

from base-starter-react.

amahdy avatar amahdy commented on May 29, 2024

At least yarn install works.

Right now there is a big inconsistency between instructions listed on the /start pages and the downloaded zip file. So we need to at least download a properly working zip file.

  1. We do not want to have bower instructions highlighted on our website.
  2. We want to provide a working version of the source code with latest p3 features for front-end developers that do not care about Vaadin platform version.

Please switch the download to use the p3-preview zip file for now. Thanks

from base-starter-react.

web-padawan avatar web-padawan commented on May 29, 2024

We want to provide a working version of the source code with latest p3 features for front-end developers that do not care about Vaadin platform version.
It is not working. Installing dependencies obviously works, but building does not.

Once we release V12 with the official Polymer 3 support, we will be able to switch starters to use it in case if these issues are fixed by that time (some of those are related to React tools).

from base-starter-react.

amahdy avatar amahdy commented on May 29, 2024

Good, but for now, /start is a public web page and must contain a working zip file. If you can fix #3572 would be greatly appreciated, otherwise I need to talk to someone from the website team.

from base-starter-react.

web-padawan avatar web-padawan commented on May 29, 2024

The zip file there is working, they should update starting instructions to match readme.

from base-starter-react.

amahdy avatar amahdy commented on May 29, 2024
  1. We do not want to have bower instructions highlighted on our website.

Vaadin 12 still has few months to go.

from base-starter-react.

web-padawan avatar web-padawan commented on May 29, 2024

Fixed by #16 on the p3-preview branch, will merge to master once other starters are fixed.

from base-starter-react.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.