Comments (4)
We can leave the width of date picker and time picker as is by default for now, but to make it possible to make more horizontally compact field we should introduce some predefined theme variants to control the width of time picker (and maybe also date picker?).
But imo these new theme variants should be implemented within vaadin-time-picker (and optionally vaadin-date-picker) so that they can also be used in those components, and they would automatically be available to use also via setting a theme attribute for vaadin-date-time-picker.
To allow controlling the width of date picker and time picker separately we could e.g. make sure to prefix or suffix those theme variant names with date
/time
so we can pass them as is in date-time-picker.
Some ideas for theme variant names for time picker:
time-width-hours
("00:00")time-width-hours-12h
("00:00 AM")time-width-seconds
("00:00:00")time-width-seconds-12h
("00:00:00 AM")time-width-milliseconds
("00:00:00.000")
Date picker could have similar variants for some most common date formats
from vaadin-date-time-picker.
Related discussion about the width of the component(s) (mainly time picker): https://vaadin.slack.com/archives/C3TGRP4HY/p1571296778094300
from vaadin-date-time-picker.
Yes, I agree that these variants should be in the contained components, not just date-time-picker.
time-width-hours
should IMO be time-width-mins
instead, as it is showing minutes as well.
What happens when an explicit width is set on the date-time-picker? How do the fields shrink/grow?
from vaadin-date-time-picker.
time-width-hours
should IMO betime-width-mins
instead, as it is showing minutes as well.
That's what I meant to write but somehow wrote hours instead. :)
from vaadin-date-time-picker.
Related Issues (20)
- Add support for getting initial value from slotted fields
- Remove ugly workaround of overriding customField.validate method
- Disabled styles for the label
- Add styling demos HOT 1
- Implement validation
- Implement the MVP
- Implement 'change' event
- Implement focus() and autofocus
- Clearing the value is not reflected in date picker and time picker
- Add properties that can be forwarded to the sub-components directly HOT 1
- Implement autoOpenDisabled
- Add helper text slot and API
- Generate TypeScript definitions for P3
- Add min/max and i18n properties
- Broken links HOT 1
- Polymer 3 conversion and TS event type definitions
- Make sure the component is accessible
- DateTimePicker#getErrorMessage() not working
- Tabbing does not work in Chrome HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vaadin-date-time-picker.