Giter Site home page Giter Site logo

Comments (4)

Haprog avatar Haprog commented on June 29, 2024 1

We can leave the width of date picker and time picker as is by default for now, but to make it possible to make more horizontally compact field we should introduce some predefined theme variants to control the width of time picker (and maybe also date picker?).

But imo these new theme variants should be implemented within vaadin-time-picker (and optionally vaadin-date-picker) so that they can also be used in those components, and they would automatically be available to use also via setting a theme attribute for vaadin-date-time-picker.

To allow controlling the width of date picker and time picker separately we could e.g. make sure to prefix or suffix those theme variant names with date/time so we can pass them as is in date-time-picker.

Some ideas for theme variant names for time picker:

  • time-width-hours ("00:00")
  • time-width-hours-12h ("00:00 AM")
  • time-width-seconds ("00:00:00")
  • time-width-seconds-12h ("00:00:00 AM")
  • time-width-milliseconds ("00:00:00.000")

Date picker could have similar variants for some most common date formats

from vaadin-date-time-picker.

Haprog avatar Haprog commented on June 29, 2024

Related discussion about the width of the component(s) (mainly time picker): https://vaadin.slack.com/archives/C3TGRP4HY/p1571296778094300

from vaadin-date-time-picker.

jouni avatar jouni commented on June 29, 2024

Yes, I agree that these variants should be in the contained components, not just date-time-picker.

time-width-hours should IMO be time-width-mins instead, as it is showing minutes as well.

What happens when an explicit width is set on the date-time-picker? How do the fields shrink/grow?

from vaadin-date-time-picker.

Haprog avatar Haprog commented on June 29, 2024

time-width-hours should IMO be time-width-mins instead, as it is showing minutes as well.

That's what I meant to write but somehow wrote hours instead. :)

from vaadin-date-time-picker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.